[GitHub] trafficserver issue #806: TS-4304: implementation of ConditionUrl::append_va...

2016-08-08 Thread sudheerv
Github user sudheerv commented on the issue: https://github.com/apache/trafficserver/pull/806 This is an automatically generated message. sudhe...@yahoo-inc.com is no longer with Yahoo! Inc. Your message will not be forwarded. If you have a sales

[GitHub] trafficserver issue #806: TS-4304: implementation of ConditionUrl::append_va...

2016-08-08 Thread yatsukhnenko
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/806 @zwoop, did you look at this? What's wrong? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #806: TS-4304: implementation of ConditionUrl::append_va...

2016-07-29 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/806 I'll look again later, but I don't think so. At least it should work on more than just the pristine request URL. The intent of these is to support various types of the URLs for different types

[GitHub] trafficserver issue #806: TS-4304: implementation of ConditionUrl::append_va...

2016-07-29 Thread yatsukhnenko
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/806 @zwoop, I added the same features as in eval method --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #806: TS-4304: implementation of ConditionUrl::append_va...

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/806 This is a good start, but it's missing a few things (I think at least, been a while since I looked at this). Look at how the eval() function is handling the different cases. But at least I