Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/833
Because I thought it's the easiest way. I could parse query parameters and
use a specific parameter as a trigger but it needs more codes. I wanted to keep
the example plugin simple. I'd happy
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/833
By removing TSUrlHttpQueryGet() I meant, I was always returning true in the
function.
Why are you determining if it should push based on the length of the query
string in the URL?
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/683/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/787/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/833
@bryancall That's odd. I just rebased again but I don't see any problems.
> After removing TSUrlHttpQueryGet() from the plugin I am seeing many
server pushes for the URL in the logs.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/833
I had problems getting it to work. I had problems with the plugin failing
from TSUrlHttpQueryGet() in the plugin. After removing TSUrlHttpQueryGet()
from the plugin I am seeing many
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/833
It works now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/659/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/763/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/833
It doesn't work correctly after the rebasing. I'm working on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/756/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/652/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/638/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/742/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/637/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/741/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/833
Rebased for now. We still needs discuss about `url` argument.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/833
@maskit Can you please update this pull request? I would like to get this
in this week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/416/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/519/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user masaori335 commented on the issue:
https://github.com/apache/trafficserver/pull/833
Looks good. Please squash commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/397/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/500/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/833
Trying another build, for some reason builds are not stable now [approve
ci].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/392/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/495/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/494/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/391/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/390/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/493/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/833
@maskit Yeh, saw the email now :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/833
@jpeach Which parts of changes are those? I think all changes are related
to the API or Server Push.
@zwoop I sent a API proposal to dev@ about 11 hours ago. Please let me know
if it
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/833
Also, even with this being an experimental API, I think we should go
through the normal API review process for this, right?
---
If your project is set up for it, you can reply to this email
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/833
There are quite a few changes that seem unrelated to the proposed API. Can
you separate those out into an independent PR?
---
If your project is set up for it, you can reply to this email and
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/833
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/492/ for details.
---
If your project is set up for it, you can reply to this email and have your
35 matches
Mail list logo
