Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/834
@pbchou - Yeah we missed 7.0, everyone including myself were working on
patches and bug fixes for 7.0 from a recent bug scrub. As for these PR's they
could go in for 7.1 and later. I
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@jrushford -- I see they branched 7.0.x already. Would this PR get merged
into both master and 7.0.x or did we miss the boat? Also, please see the
regression test cases that I added at your
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@jrushford -- Added regression test cases for "-R3 -r PARENTSELECTION".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/834
@pbchou, thanks i look at this and get an API review started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@jrushford -- The API enhancements have been removed (moved into TS-4853).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/834
@pbchou - we have to do an api review on the two new api calls and since
they are different features from the max dirs and fname additions. They really
ought to be in separate pr's. Is it
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/834
@pbchou - Could you add parent selection and sdk api regression tests. See
ParentSelection.cc and InkAPITest.cc. You may run thest tests using
traffic_server -R3 PARENTSELECTION and
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/834
IMO, the proposal of fname and maxdirs is a bit of a hack, solving a subset
of all possible use cases. Allowing for a "parent selection URL" that can be
the same, or different, than the
Github user PSUdaemon commented on the issue:
https://github.com/apache/trafficserver/pull/834
@pbchou,
This looks OK to me now. You have one comment above from @jpeach to address
and then I think @jrushford can merge this.
Thanks!
---
If your project is set up for
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/834
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/771/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/834
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/667/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user PSUdaemon commented on the issue:
https://github.com/apache/trafficserver/pull/834
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@PSUdaemon @jpeach @zwoop @jrushford -- Phil, please see the changes that
you recommended.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@PSUdaemon @jpeach @zwoop @jrushford -- Phil, please see the changes that
you recommended.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@jpeach @zwoop @jrushford -- James, please see the changes that you
requested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/834
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/748/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/834
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/644/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/834
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/834
@zwoop and @jpeach, I'm +1 on this, would appreciate it if you could take a
look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@jrushford -- I pushed a new commit with your recommended changes. I didn't
squash it yet so you can see just the diff from what you reviewed earlier. I
also updated the API and Lua API
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@jrushford -- Thanks for taking a look, but can we hold off on squashing
commits until the branch is finalized (or alternatively just squash as part of
the merge with "git merge --squash")? I
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/834
@pbchou - I'm reviewing but, is it possible to squash the 4 commits to a
single commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@zwoop @jrushford -- I pushed another commit which removes the use of the
MIME header. It adds pointers to the HttpTransact::State's
cache_info.lookup_url and cache_info.parent_selection_url
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@jrushford -- I did consider something similar before going with the MIME
header approach. I also considered extending the HttpRequestHeader with
additional data elements. It seems that the
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/834
@zwoop @pbchou - This looks okay to me but, what do you think of modifying
the parent selection API to pass the Http transaction state then there would be
no need for the mime header.
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/834
I haventâ had a chance to look at it but, Iâll do that today.
Thanks
--
John J. Rushford
jrushf...@apache.org
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/834
@jrushford @zwoop Hi has anyone had a chance to review this? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/834
I think I'm ok with this for now, but I really wish we'd done something
similar to TSHttpTxnCacheLookupUrlGet() / TSHttpTxnCacheLookupUrlSet(), but for
the parent selection URL to use. Like
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/834
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/396/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/834
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/499/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/834
@jrushford Please review. [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
31 matches
Mail list logo
