[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

2017-03-10 Thread SolidWallOfCode
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/1534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

2017-03-08 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1534#discussion_r105075862 --- Diff: iocore/net/P_UnixNetVConnection.h --- @@ -149,21 +149,21 @@ class UnixNetVConnection : public NetVConnection // called when

[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

2017-03-08 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1534#discussion_r105075732 --- Diff: proxy/http/HttpSM.cc --- @@ -8057,14 +8059,13 @@ HttpSM::is_redirect_required() // Fill in the client protocols used.

[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

2017-03-07 Thread maskit
Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1534#discussion_r104723567 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -685,6 +687,23 @@ HttpTransactHeaders::insert_server_header_in_response(const char *server_tag, in

[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

2017-03-07 Thread maskit
Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1534#discussion_r104721541 --- Diff: proxy/http/HttpSM.cc --- @@ -8057,14 +8059,13 @@ HttpSM::is_redirect_required() // Fill in the client protocols used. Return the

[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

2017-03-04 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/1534 Use StringView for protocol stack to avoid calling strlen on strings with a known length. This is an alternative proposal to #1520. You can merge this pull request into a Git