[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r108756464 --- Diff: doc/admin-guide/plugins/gzip.en.rst --- @@ -141,6 +141,26 @@ will leave the header intact if the client provided it. - For when the

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r108756275 --- Diff: doc/admin-guide/plugins/gzip.en.rst --- @@ -141,6 +141,26 @@ will leave the header intact if the client provided it. - For when the

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r108296389 --- Diff: doc/admin-guide/plugins/gzip.en.rst --- @@ -162,6 +182,32 @@ might create a configuration with the following options:: disallow

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r108296418 --- Diff: doc/admin-guide/plugins/gzip.en.rst --- @@ -162,6 +182,32 @@ might create a configuration with the following options:: disallow

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r108296435 --- Diff: doc/admin-guide/plugins/gzip.en.rst --- @@ -162,6 +182,32 @@ might create a configuration with the following options:: disallow

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r107666043 --- Diff: plugins/gzip/gzip.cc --- @@ -115,20 +142,32 @@ gzip_data_destroy(GzipData *data) } static TSReturnCode

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r106037813 --- Diff: plugins/gzip/gzip.cc --- @@ -350,30 +435,89 @@ gzip_transform_finish(GzipData *data) if (data->downstream_length !=

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

Github user myraid commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r105300325 --- Diff: plugins/gzip/gzip.cc --- @@ -95,18 +104,29 @@ gzip_data_alloc(int compression_type) } } + if(compression_type ==

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r105279083 --- Diff: plugins/gzip/gzip.cc --- @@ -95,18 +104,29 @@ gzip_data_alloc(int compression_type) } } + if(compression_type

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

GitHub user myraid opened a pull request: https://github.com/apache/trafficserver/pull/1557 brotli support in gzip plugin The requirements are outlined in https://github.com/apache/trafficserver/issues/1555 @bryancall @shukitchan can you review. You can merge this pull