[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754849#comment-13754849
]
ASF subversion and git services commented on TS-2145:
-
Commit
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753602#comment-13753602
]
Yunkai Zhang commented on TS-2145:
--
I have submitted V2 here, which reflects our discussion
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753603#comment-13753603
]
ASF subversion and git services commented on TS-2145:
-
Commit
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752429#comment-13752429
]
Leif Hedstrom commented on TS-2145:
---
Nice! Couple of minor thought:
1) Why not add an
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752461#comment-13752461
]
Yunkai Zhang commented on TS-2145:
--
1)~3) ok for me:)
4) I had tried to use switch
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752466#comment-13752466
]
Yunkai Zhang commented on TS-2145:
--
I'll give V2 later, thanks.
Add
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752478#comment-13752478
]
Leif Hedstrom commented on TS-2145:
---
On 4: Hmmm, if that's the case, then the place(s)
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752480#comment-13752480
]
Leif Hedstrom commented on TS-2145:
---
For 4, I'm talking about e.g.
{code}
+switch
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752483#comment-13752483
]
Yunkai Zhang commented on TS-2145:
--
They are different:), *ret_val* is not in loop, it's
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752488#comment-13752488
]
Leif Hedstrom commented on TS-2145:
---
But it's using the same return type, and it's
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752493#comment-13752493
]
Yunkai Zhang commented on TS-2145:
--
Why I make the test for LOG_OK to be the 2th
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752497#comment-13752497
]
Yunkai Zhang commented on TS-2145:
--
Yes, the bitwise return value will confuse the upper
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752501#comment-13752501
]
Yunkai Zhang commented on TS-2145:
--
Oh, don't worry. The upper caller have been checking the
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752499#comment-13752499
]
Leif Hedstrom commented on TS-2145:
---
I still don't get it :) Why is that better than
{code}
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752503#comment-13752503
]
Leif Hedstrom commented on TS-2145:
---
So, if you make that change (LOG_OK = 0), the code
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752504#comment-13752504
]
Leif Hedstrom commented on TS-2145:
---
The latter ought to be the generic way to check for
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752507#comment-13752507
]
Yunkai Zhang commented on TS-2145:
--
No, The reason I change LOG_OK to 1 is that I want to
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752533#comment-13752533
]
Yunkai Zhang commented on TS-2145:
--
Just think about they are priority node chains:
FAIL
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752539#comment-13752539
]
Leif Hedstrom commented on TS-2145:
---
Gotcha. That makes sense. Maybe put that in a comment
[
https://issues.apache.org/jira/browse/TS-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752542#comment-13752542
]
Yunkai Zhang commented on TS-2145:
--
good idea, It's too late to cook V2 now, let's do it
20 matches
Mail list logo
