[ https://issues.apache.org/jira/browse/TS-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709439#comment-14709439 ]
ASF subversion and git services commented on TS-3865: ----------------------------------------------------- Commit 253c55a1c33048584032e2343eb47259da7c272a in trafficserver's branch refs/heads/master from shinrich [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=253c55a ] TS-3865: CID 1317247 and 1317248: Null pointer dereference > CID 1317247 and 1317248: Null pointer dereference > ------------------------------------------------- > > Key: TS-3865 > URL: https://issues.apache.org/jira/browse/TS-3865 > Project: Traffic Server > Issue Type: Bug > Components: HTTP > Reporter: Leif Hedstrom > Assignee: Susan Hinrichs > Fix For: 6.1.0 > > > I believe the is from c181e7eea93592: > {code} > New defect(s) Reported-by: Coverity Scan > Showing 2 of 2 defect(s) > ** CID 1317248: Null pointer dereferences (FORWARD_NULL) > /iocore/net/UnixNetVConnection.cc: 1395 in > UnixNetVConnection::migrateToCurrentThread(Continuation *, EThread *)() > ________________________________________________________________________________________________________ > *** CID 1317248: Null pointer dereferences (FORWARD_NULL) > /iocore/net/UnixNetVConnection.cc: 1395 in > UnixNetVConnection::migrateToCurrentThread(Continuation *, EThread *)() > 1389 > 1390 // Create new VC: > 1391 NetVConnection *new_vc = NULL; > 1392 if (save_ssl) { > 1393 new_vc = sslNetProcessor.allocate_vc(t); > 1394 SSLNetVConnection *sslvc = dynamic_cast<SSLNetVConnection > *>(new_vc); > CID 1317248: Null pointer dereferences (FORWARD_NULL) > Passing null pointer "sslvc" to "populate", which dereferences it. (The > dereference happens because this is a virtual function call.) > 1395 if (sslvc->populate(hold_con, cont, save_ssl) != EVENT_DONE) { > 1396 sslvc->do_io_close(); > 1397 sslvc = NULL; > 1398 } > 1399 return sslvc; > 1400 // Update the SSL fields > ** CID 1317247: Null pointer dereferences (FORWARD_NULL) > /iocore/net/UnixNetVConnection.cc: 1404 in > UnixNetVConnection::migrateToCurrentThread(Continuation *, EThread *)() > ________________________________________________________________________________________________________ > *** CID 1317247: Null pointer dereferences (FORWARD_NULL) > /iocore/net/UnixNetVConnection.cc: 1404 in > UnixNetVConnection::migrateToCurrentThread(Continuation *, EThread *)() > 1398 } > 1399 return sslvc; > 1400 // Update the SSL fields > 1401 } else { > 1402 new_vc = netProcessor.allocate_vc(t); > 1403 UnixNetVConnection *netvc = dynamic_cast<UnixNetVConnection > *>(new_vc); > CID 1317247: Null pointer dereferences (FORWARD_NULL) > Passing null pointer "netvc" to "populate", which dereferences it. (The > dereference happens because this is a virtual function call.) > 1404 if (netvc->populate(hold_con, cont, save_ssl) != EVENT_DONE) { > 1405 netvc->do_io_close(); > 1406 netvc = NULL; > 1407 } > 1408 return netvc; > 1409 } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)