[ https://issues.apache.org/jira/browse/YUNIKORN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174206#comment-17174206 ]
Wilfred Spiegelenburg edited comment on YUNIKORN-112 at 8/10/20, 12:04 PM: --------------------------------------------------------------------------- Updates that do not fit under the rest of the jiras: - fix issues in the readme and release instructions on how we release - add a {{.gitignore}} file that excludes the staging directory from commits - moved from DISCLAIMER-WIP to DISCLAIMER - LICENSE file turned out to be empty and in the wrong location (introduced in YUNIKORN-127) - remove landmark directory from the released artefacts was (Author: wifreds): Updates that do not fit under the rest of the jiras: - fix issues in the readme and release instructions on how we release - add a {{.gitignore}} file that excludes the staging directory from commits - moved from DISCLAIMER-WIP to DISCLAIMER - NOTICE file turned out to be empty and in the wrong location (introduced in YUNIKORN-127) - remove landmark directory from the released artefacts > Fix ASF release issues > ---------------------- > > Key: YUNIKORN-112 > URL: https://issues.apache.org/jira/browse/YUNIKORN-112 > Project: Apache YuniKorn > Issue Type: Task > Components: release > Reporter: Weiwei Yang > Assignee: Wilfred Spiegelenburg > Priority: Blocker > > Felix gives us some feedback on our first release, we should make sure they > are fixed in the next release, items include: > - incubating in name > - signature and hash fine > - DISCLAIMER is ok - as above > - LICENSE and NOTICE are fine > - Ok with binary files - see note below > - See note below on ASF headers > - didn't compile from source > 1. SHOULD: instead of a personal directory, release SHOULD be staged on > [https://dist.apache.org/repos/dist/dev/incubator/yunikorn]. > [https://incubator.apache.org/guides/releasemanagement.html#podling_constraints] > this include the signing KEYS file that should be kept as a project KEYS file > instead of a personal one/location > 2. it is a bit strange that you have 5 LICENSE files, you can exclude the one > in subdirectories when you build the source tarball? > 3. might want to check the license for the image files: png, jpg - where are > they from? > 4. SHOULD: a large number of files should also have ASF headers, eg. .mod, > .yaml, .md, .go > 5. nice to have: more details on go setup for dev environment (maybe just a > quick link), go setup info without GoLand IDE. It could be helpful to know > more on how to build (is this the build step? > [https://github.com/apache/incubator-yunikorn-core/blob/master/docs/developer-guide.md#core-component-build]) > 6. SHOULD: put Apache Incubator logo on the > websitehttps://[incubator.apache.org/guides/press-kit.html|http://incubator.apache.org/guides/press-kit.html] > [http://yunikorn.apache.org/] -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org For additional commands, e-mail: issues-h...@yunikorn.apache.org