[
https://issues.apache.org/jira/browse/ZOOKEEPER-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zili Chen resolved ZOOKEEPER-666.
---------------------------------
Assignee: Zili Chen
Resolution: Fixed
Resolved alongside ZOOKEEPER-837.
> Unsafe publication in client API
> --------------------------------
>
> Key: ZOOKEEPER-666
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-666
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.2.2
> Reporter: Martin Traverso
> Assignee: Zili Chen
> Priority: Major
>
> The following code may result in a data race due to unsafe publication of a
> reference to "this". The call to cnxn.start() spawns threads that have access
> to the partially-constructed reference to the ZooKeeper object.
> See http://www.ibm.com/developerworks/java/library/j-jtp0618.html for some
> background info.
> {noformat}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher)
> throws IOException
> {
> .....
> cnxn = new ClientCnxn(connectString, sessionTimeout, this,
> watchManager);
> cnxn.start();
> }
> {noformat}
> The obvious fix is to move the call to cnxn.start() into a separate start()
> method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
