[
https://issues.apache.org/jira/browse/IMPALA-12372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755702#comment-17755702
]
ASF subversion and git services commented on IMPALA-12372:
----------------------------------------------------------
Commit 5d0a2f01a52f2660acc1f0f4b3214ca6ecfa66ce in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5d0a2f01a ]
IMPALA-12372: Only use -Wno-deprecated-declaration for OpenSSL3
Redhat 9 and Ubuntu 22.04 both use OpenSSL3, which deprecated
several APIs that we use. To support those platforms, we added
the -Wno-deprecated-declaration to the build. Historically, the
Impala build has also specified -Wno-deprecated due to
use of deprecated headers in gutils. These flags limit our
ability to notice use of deprecated code in other parts of the
code.
The code in gutils no longer requires -Wno-deprecated, so
this removes it completely. Additionally, this limits the
-Wno-deprecated-declaration flag to machines using
OpenSSL 3.
Reenabling deprecation warnings also reenables Clang Tidy's
clang-diagnostic-deprecated enforcement. This is currently
broken, so this turns off clang-diagnostic-deprecated
until it can be addressed properly.
Testing:
- Ran build-all-options on Ubuntu 22 and Ubuntu 16
- Ran a Rocky 9.2 build
Change-Id: I1b36450d084f342eeab5dac2272580ab6b0c988b
Reviewed-on: http://gerrit.cloudera.org:8080/20369
Reviewed-by: Laszlo Gaal <laszlo.g...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <borokna...@cloudera.com>
Tested-by: Joe McDonnell <joemcdonn...@cloudera.com>
> Only use -Wno-deprecated / -Wno-deprecated-declaration for OpenSSL3
> -------------------------------------------------------------------
>
> Key: IMPALA-12372
> URL: https://issues.apache.org/jira/browse/IMPALA-12372
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> As part of supporting Redhat 9 / Ubuntu 22, those platforms use OpenSSL3 and
> compilation will produce warnings that fail our build (due to -Werror). The
> original change turned off those deprecation warnings for all platforms.
> This is overly broad. We should try to turn off those warnings only for
> platforms that use OpenSSL3. Otherwise, we are blind to other locations that
> are using deprecated functions. This came up when investigating using
> googletest 1.12.1 (which deprecated some calls we use).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
