[
https://issues.apache.org/jira/browse/IMPALA-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776404#comment-17776404
]
ASF subversion and git services commented on IMPALA-12490:
----------------------------------------------------------
Commit 15993606785f9a5fcce76226728eeefbf33a92fe in impala's branch
refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=159936067 ]
IMPALA-12354: Add aarch64 native-toolchain build
Pre-built toolchains are identified by a TOOLCHAIN_BUILD_ID. This commit
adds an aarch64 (64-bit ARM) native-toolchain build, separate from the
x86_64 native-toolchain build, with its own environment variable set in
impala-config.sh. bootstrap_toolchain.py selects which version to use
based on 'uname -m'.
impala-config.sh also verifies that IMPALA_TOOLCHAIN_BUILD_ID_AARCH64
and IMPALA_TOOLCHAIN_BUILD_ID_X86_64 were produced from the same
native-toolchain ref by checking the 2nd token of the build ID.
Updates package version to include the architecture tag to match how
native-toolchain now names them.
Testing:
- successfully built on ARM, and tests passed (exceptions noted in
IMPALA-12490)
Change-Id: I9bfa7125dbc647b33041c5572d97b7f7ccad6258
Reviewed-on: http://gerrit.cloudera.org:8080/20519
Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com>
Tested-by: Michael Smith <michael.sm...@cloudera.com>
> Fix tests on ARM
> ----------------
>
> Key: IMPALA-12490
> URL: https://issues.apache.org/jira/browse/IMPALA-12490
> Project: IMPALA
> Issue Type: Task
> Reporter: Michael Smith
> Assignee: Michael Smith
> Priority: Major
>
> llvm-codegen-cache-test fails on ARM with
> {code}
> /home/ubuntu/Impala/be/src/codegen/llvm-codegen-cache-test.cc:299
> Expected: (mem_charge_1) <= (codegen_cache_capacity), actual: 136 vs 128
> {code}
> Additionally an aggregation test fails on Graviton 3 instances (but not my M1
> Mac) with
> {code}
> query_test/test_aggregation.py:202: in test_aggregation
> self.run_test_case('QueryTest/aggregation', vector)
> common/impala_test_suite.py:751: in run_test_case
> self.__verify_results_and_errors(vector, test_section, result, use_db)
> common/impala_test_suite.py:587: in __verify_results_and_errors
> replace_filenames_with_placeholder)
> common/test_result_verifier.py:486: in verify_raw_results
> VERIFIER_MAP[verifier](expected, actual)
> common/test_result_verifier.py:295: in verify_query_result_is_equal
> assert expected_results == actual_results
> E assert Comparing QueryTestResults (expected vs actual):
> E 5,NULL == 5,NULL
> E 8,10414050.0 == 8,10414050
> E 12,-5125047.666666668 == 12,-5125047.666666668
> E 1,NULL == 1,NULL
> E 2,-158355.0 == 2,-158355
> E 3,-3513583.5 == 3,-3513583.500000001
> E 4,-19719420.0 == 4,-19719420
> E 6,-16848393.6 == 6,-16848393.6
> E 7,4309087.100000003 == 7,4309087.100000003
> E 9,1337692.761904765 != 9,1337692.761904766
> E 10,11663050.25 != 10,11663050.25000001
> E 11,17362201.83333334 == 11,17362201.83333334
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
