[ https://issues.apache.org/jira/browse/IMPALA-13072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851229#comment-17851229 ]
Joe McDonnell commented on IMPALA-13072: ---------------------------------------- Fixed by this commit: {noformat} commit f601ec33f2bcfaab19a46cff5fc6f0a90e22da8d Author: Joe McDonnell <joemcdonn...@cloudera.com> Date: Fri May 10 17:22:56 2024 -0700 IMPALA-13072: Add retries for s3 uploads to combat flakiness On ARM toolchain builds, we have seen some uploads to s3 fail with a segementation fault. Given the number of artifacts that the toolchain uploads, even a relatively low error rate can make it hard to get a passing build. This modifies the s3 upload code to retry up to 10 times to avoid this flakiness. Testing: - Ran an ARM toolchain build and saw the retry happen successfully - Ran a toolchain build with an invalid s3 bucket and verified it failed after 10 retries Change-Id: I95d858c99e965730303c2bfd90478ac5f68acf83 Reviewed-on: http://gerrit.cloudera.org:8080/21421 Reviewed-by: Michael Smith <michael.sm...@cloudera.com> Reviewed-by: Laszlo Gaal <laszlo.g...@cloudera.com> Tested-by: Joe McDonnell <joemcdonn...@cloudera.com> {noformat} > Toolchain: Add retries for uploading artifacts to the s3 buckets > ---------------------------------------------------------------- > > Key: IMPALA-13072 > URL: https://issues.apache.org/jira/browse/IMPALA-13072 > Project: IMPALA > Issue Type: Improvement > Components: Infrastructure > Affects Versions: Impala 4.5.0 > Reporter: Joe McDonnell > Assignee: Joe McDonnell > Priority: Major > > On ARM toolchain builds, we have seen some failures to upload tarballs to s3: > {noformat} > 22:17:06 impala-toolchain-redhat8: Uploading > /mnt/build/llvm-5.0.1-asserts-p7-gcc-10.4.0.tar.gz to > s3://native-toolchain/build/33-f93e2c9a86/llvm/5.0.1-asserts-p7-gcc-10.4.0/llvm-5.0.1-asserts-p7-gcc-10.4.0-ec2-package-centos-8-aarch64.tar.gz > 22:17:06 impala-toolchain-redhat8: /mnt/functions.sh: line 385: 680012 > Segmentation fault (core dumped) aws s3 cp --only-show-errors > "${PACKAGE_FINAL_TGZ}" "${PACKAGE_S3_DESTINATION}"{noformat} > Since we do many uploads, even a relatively low failure rate can make it hard > to get a passing build. We should change the code to retry the upload. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org