[
https://issues.apache.org/jira/browse/IMPALA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859962#comment-17859962
]
Joe McDonnell commented on IMPALA-13121:
----------------------------------------
{noformat}
commit b9167e985c69fd321e9e25e5ae0c7747682f06f6
Author: Joe McDonnell <joemcdonn...@cloudera.com>
Date: Fri May 31 15:20:20 2024 -0700 IMPALA-13121: Switch to ccache 3.7.12
The docker images currently build and use ccache 3.3.3.
Recently, we ran into a case where debuginfo was being
generated even though the cflags ended with -g0. The
ccache release history has this note for 3.3.5:
- Fixed a regression where the original order of
debug options could be lost.
This upgrades ccache to 3.7.12 to address this issue.
Ccache 3.7.12 is the last ccache release that builds
using autotools. Ccache 4 moves to build with CMake.
Adding a CMake dependency would be complicated at this
stage, because some of the older OSes don't provide a
new enough CMake in the package repositories. Since we
don't really need the new features of Ccache 4+, this
sticks with 3.7.12 for now.
This reenables the check_ccache_works() logic in
assert-dependencies-present.py.
Testing:
- Built docker images and ran a toolchain build
- The newer ccache resolves the unexpected debuginfo issue
Change-Id: I90d751445daa0dc298b634c1049d637a14afac40
Reviewed-on: http://gerrit.cloudera.org:8080/21473
Reviewed-by: Michael Smith <michael.sm...@cloudera.com>
Reviewed-by: Laszlo Gaal <laszlo.g...@cloudera.com>
Tested-by: Joe McDonnell <joemcdonn...@cloudera.com>
{noformat}
> Move the toolchain to a newer version of ccache
> -----------------------------------------------
>
> Key: IMPALA-13121
> URL: https://issues.apache.org/jira/browse/IMPALA-13121
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Affects Versions: Impala 4.5.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> The native-toolchain currently uses ccache 3.3.3. In a recent change adding
> debug info, I ran into a case where the debug level was not what I expected.
> I had added a -g0 at the end to turn off debug information for the cmake
> build, but it still ended up with debug info.
> The release notes for ccache 3.3.5 says this:
> * Fixed a regression where the original order of debug options could be
> lost. This reverts the “Improved parsing of {{-g*}} options” feature in
> ccache 3.3.
> [https://ccache.dev/releasenotes.html#_ccache_3_3_5]
> I think I may have been hitting that. We should upgrade ccache to a more
> recent version.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
