[ 
https://issues.apache.org/jira/browse/IMPALA-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476756#comment-16476756
 ] 

ASF subversion and git services commented on IMPALA-6337:
---------------------------------------------------------

Commit 465b3c4963e66188ce83315590f7fd4849165bf0 in impala's branch 
refs/heads/2.x from [~fredyw]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=465b3c4 ]

IMPALA-6337: Fix infinite loop in Impala shell

This patch fixes a bug in sqlparse where sqlparse incorrectly splits a
statement that has a new line inside double quotes. The bug in sqlparse
causes Impala shell to go to infinite loop when a statement contains a
new line inside double quotes.

The patch in sqlparse is based on the upstream fix at
https://github.com/andialbrecht/sqlparse/pull/396

Testing:
- Added new end-to-end shell tests
- Ran end-to-end shell tests

Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b
Reviewed-on: http://gerrit.cloudera.org:8080/9195
Reviewed-by: David Knupp <dkn...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> Infinite loop in impala_shell.py
> --------------------------------
>
>                 Key: IMPALA-6337
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6337
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Clients
>    Affects Versions: Impala 2.10.0
>            Reporter: Jinchul Kim
>            Assignee: Fredy Wijaya
>            Priority: Major
>              Labels: newbie
>             Fix For: Impala 2.13.0, Impala 3.1.0
>
>
> I faced the infinite loop when I ran an example below. In my initial 
> investigation using pdb, sanitise_input -> precmd -> onecmd -> postcmd -> 
> santise_input -> ...
> Here is a reproduction scenario:
> {noformat}
> select '1\'23\'4'";
> ;
> "
> ;
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to