[
https://issues.apache.org/jira/browse/IMPALA-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889198#comment-16889198
]
ASF subversion and git services commented on IMPALA-8176:
---------------------------------------------------------
Commit 4cc3ff9c6763de10236df351a47324d662766de3 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=4cc3ff9 ]
IMPALA-8176: Convert simple backend tests to the unified executable
This converts tests with trivial main() functions to the unified
executable. This means that the code change is strictly removing
main() functions and updating the CMakeLists.txt files. Any test
that requires a change larger than that will be addressed
separately. The only exceptions are:
- exec/incr-stats-util-test.cc requires naming changes to avoid
conflicts with util/rle-test.cc
- runtime/decimal-test.cc simplified the naming to make the
CMakeLists.txt arguments easier.
The new test libraries are marked STATIC, because they are linked
into a single binary (unifiedbetests) and googletest has problems
with tests in shared libraries.
Converting this set of tests saves about 18GB of disk
space for a debug build and saves a minute or two of link time.
For any CMakeLists.txt that has unified tests, this adds a comment
for each test that is not unified.
Testing:
- Ran backend tests in DEBUG and ASAN modes on Centos7
- Ran backend tests in DEBUG mode on Centos6
Change-Id: I840d0f9b70edb3a7195a2a33b21fd2874d4c52bd
Reviewed-on: http://gerrit.cloudera.org:8080/13515
Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Convert tests with trivial main() functions to use a unified executable
> -----------------------------------------------------------------------
>
> Key: IMPALA-8176
> URL: https://issues.apache.org/jira/browse/IMPALA-8176
> Project: IMPALA
> Issue Type: Sub-task
> Components: Infrastructure
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> With the initial commit for the unified backend test executable commited
> (IMPALA-8071), it should be straight-forward to convert another set of tests
> to use the unified executable. Any test with a simple main() function (such
> as IMPALA_TEST_MAIN()) should require only modest changes to convert.
> Command to find such tests:
> git grep IMPALA_TEST_MAIN
> It looks like there are dozens of such tests:
> {noformat}
> joe@joemcdonnell:~/Impala$ git grep IMPALA_TEST_MAIN\(\) | wc -l
> 38
> {noformat}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
