[
https://issues.apache.org/jira/browse/IMPALA-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969988#comment-16969988
]
ASF subversion and git services commented on IMPALA-9129:
---------------------------------------------------------
Commit f9cf70d0352196e7b1b8465d6507ae4b16a3e82c in impala's branch
refs/heads/master from David Knupp
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f9cf70d ]
IMPALA-9129: Add a test fixture that cleans up intentional core dumps
Some negative tests produce core dumps intentionally. We should have a
way of removing these as part of test cleanup.
For custom cluster tests, it's likely the cores may actually be generated
during the base class setup phase, which means it's too early for the
test fixture to really be useful. Such was the case with the test case
TestAuthorizationProvider::test_invalid_provider_flag. In this instance,
we had to add the same steps directly to the tests.
Testing done:
For test_invalid_provider_flag, I made sure I had pre-existing core files
in the IMPALA_HOME directory, then ran the test to confirm new cores were
removed.
-- 2019-11-06 19:53:27,303 INFO MainThread: Removing core.impalad.61852
created by test_invalid_provider_flag
-- 2019-11-06 19:53:27,375 INFO MainThread: Removing core.impalad.61856
created by test_invalid_provider_flag
-- 2019-11-06 19:53:27,450 INFO MainThread: Removing core.impalad.61849
created by test_invalid_provider_flag
...and then made sure the pre-existing cores were still present.
Change-Id: I778f27e820a6983894c1294d35627ddb04f5a51a
Reviewed-on: http://gerrit.cloudera.org:8080/14640
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Provide a way for negative tests to remove intentionally generated core dumps
> -----------------------------------------------------------------------------
>
> Key: IMPALA-9129
> URL: https://issues.apache.org/jira/browse/IMPALA-9129
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Reporter: David Knupp
> Assignee: David Knupp
> Priority: Major
>
> Occasionally, tests (esp. custom cluster tests) will inject an error or set
> some invalid config, expecting Impala to generate a core dump.
> We should have a general way for such files to delete the bogus core dumps,
> otherwise they can complicate/confuse later triaging efforts of legitimate
> test failures.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
