Michael Ho created IMPALA-8480: ---------------------------------- Summary: Replace ScopedFlagSetter with google::FlagSaver Key: IMPALA-8480 URL: https://issues.apache.org/jira/browse/IMPALA-8480 Project: IMPALA Issue Type: Improvement Components: Infrastructure Reporter: Michael Ho
[~tlipcon] pointed out that in [code review |https://gerrit.cloudera.org/#/c/12987/7/be/src/runtime/io/data-cache-test.cc@274]{{google::FlagSaver}} already saves the state of all flags at time of construction and restores all of them on destruction. Currently, we rely on {{ScopedFlagSetter}} to save and restore modified flags in BE tests. We need to define a {{ScopedFlagSetter}} object per modified flags. It seems less clumsy for BE tests if all of them inherit from a base class which has {{google::FlagSaver}} as a class member. In this way, all modified flags in BE tests will be automatically restored and there is no need for a separate {{ScopedFlagSetter}} per modified flag. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org