[jira] [Commented] (VFS-307) VFS issues a lot of FTP commands when listing a directory
[ https://issues.apache.org/jira/browse/VFS-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1319#comment-1319 ] Ibrahim Hasbini commented on VFS-307: - Hello Mario, I've been debugging an issue where folder creation was failing and found the method FTPFile[] listFilesInDirectory(String relPath) in FTPClientWrapper and this issue. It seems some FTP servers do not return an error code when the LIST command gets a path that contains space, but simply return an empty list of files and a success code. This causes solution 2 mentioned above to never fallback to change directory + list, this later causes VFS to think that a folder does not exist while in reality it does (eventually causing an exception when we try to create that existing folder). Is it ok to always fallback to change directory + list when a path contains spaces? Thanks. VFS issues a lot of FTP commands when listing a directory - Key: VFS-307 URL: https://issues.apache.org/jira/browse/VFS-307 Project: Commons VFS Issue Type: Improvement Reporter: Mario Ivankovits Fix For: Nightly Builds Hello Mario, We at JetBrains are implementing support for (S)FTP sync in our IDEs using Commons VFS. When looking at the performance, we noticed that FTP provider is somewhat not perfect: see my discussion with Ralph. So the question is: why FtpClientWrapper changes the current directory to issue 'LIST' command and restoring it back afterwards instead of issuing single 'LIST relpath'? Subversion says it was you who introduced this behavior far back in 2008. Hope you remember those times and reason why you did this. Thanks a lot in advance, Kirill Safonov JetBrains, Inc http://www.jetbrains.com Develop with pleasure! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (VFS-307) VFS issues a lot of FTP commands when listing a directory
[ https://issues.apache.org/jira/browse/VFS-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863727#action_12863727 ] Mario Ivankovits commented on VFS-307: -- The change happened when implementing the umbrella issue [1] more concret it was the issue [2] for which we did this. Hmmm ... So, I see three ways to move on: 1) leave as is, which surely is a performance penalty and not good for any DIE 2) change to try first LIST path and fallback to the current way if directory is not found 3) change to LIST path and try to escape the path in a way which makes it work with spaces in it I'll try to see if I can make 3 work and go up the list then :-) VFS issues a lot of FTP commands when listing a directory - Key: VFS-307 URL: https://issues.apache.org/jira/browse/VFS-307 Project: Commons VFS Issue Type: Improvement Reporter: Mario Ivankovits Hello Mario, We at JetBrains are implementing support for (S)FTP sync in our IDEs using Commons VFS. When looking at the performance, we noticed that FTP provider is somewhat not perfect: see my discussion with Ralph. So the question is: why FtpClientWrapper changes the current directory to issue 'LIST' command and restoring it back afterwards instead of issuing single 'LIST relpath'? Subversion says it was you who introduced this behavior far back in 2008. Hope you remember those times and reason why you did this. Thanks a lot in advance, Kirill Safonov JetBrains, Inc http://www.jetbrains.com Develop with pleasure! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-307) VFS issues a lot of FTP commands when listing a directory
[ https://issues.apache.org/jira/browse/VFS-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863749#action_12863749 ] Kirill Safonov commented on VFS-307: [1] VFS-210 [2] VFS-123 VFS issues a lot of FTP commands when listing a directory - Key: VFS-307 URL: https://issues.apache.org/jira/browse/VFS-307 Project: Commons VFS Issue Type: Improvement Reporter: Mario Ivankovits Hello Mario, We at JetBrains are implementing support for (S)FTP sync in our IDEs using Commons VFS. When looking at the performance, we noticed that FTP provider is somewhat not perfect: see my discussion with Ralph. So the question is: why FtpClientWrapper changes the current directory to issue 'LIST' command and restoring it back afterwards instead of issuing single 'LIST relpath'? Subversion says it was you who introduced this behavior far back in 2008. Hope you remember those times and reason why you did this. Thanks a lot in advance, Kirill Safonov JetBrains, Inc http://www.jetbrains.com Develop with pleasure! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-307) VFS issues a lot of FTP commands when listing a directory
[ https://issues.apache.org/jira/browse/VFS-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863765#action_12863765 ] Mario Ivankovits commented on VFS-307: -- It seems there is no FTP spec which allows to escape/quote a path so that it works on each and every ftp server. So I landed at solution 2 similar to what the patch in VFS-123 proposed. It seems to work with my ftp server. VFS issues a lot of FTP commands when listing a directory - Key: VFS-307 URL: https://issues.apache.org/jira/browse/VFS-307 Project: Commons VFS Issue Type: Improvement Reporter: Mario Ivankovits Fix For: Nightly Builds Hello Mario, We at JetBrains are implementing support for (S)FTP sync in our IDEs using Commons VFS. When looking at the performance, we noticed that FTP provider is somewhat not perfect: see my discussion with Ralph. So the question is: why FtpClientWrapper changes the current directory to issue 'LIST' command and restoring it back afterwards instead of issuing single 'LIST relpath'? Subversion says it was you who introduced this behavior far back in 2008. Hope you remember those times and reason why you did this. Thanks a lot in advance, Kirill Safonov JetBrains, Inc http://www.jetbrains.com Develop with pleasure! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
