Re: #20 [PATCH] add(mbsync-get-cert): support STARTTLS and custom port

2024-09-29 Thread Oswald Buddenhagen via isync-devel
On Sun, Sep 29, 2024 at 12:18:14PM +, Behnam Lal Moghaddam wrote: I just didn't bother to change the name ever, so that pseudonym has been used more often than my real name. heh, ok. i made a few fixups. unless you see something wrong with it, i'll push this version at some point. From 33b

Re: Re: #20 [PATCH] add(mbsync-get-cert): support STARTTLS and custom port

2024-09-29 Thread Oswald Buddenhagen via isync-devel
On Sat, Sep 28, 2024 at 11:54:56PM +, Behnam Lal Moghaddam wrote: On 24/09/28 02:03PM, Oswald Buddenhagen via isync-devel wrote: a few suggestions: I rewrote the patch according to your suggestions. ok. i see you removed the port config entirely, which is fair enough. however, i don't q

Re: #20 [PATCH] add(mbsync-get-cert): support STARTTLS and custom port

2024-09-28 Thread Oswald Buddenhagen via isync-devel
On Sat, Sep 28, 2024 at 09:23:49AM +, Behnam Lal Moghaddam wrote: I want to share a patch that allows mbsync-get-cert script to support STARTTLS and custom port. thanks! a few suggestions: - use true/false for $STARTTLS - then you can evaluate it without running it through `test` - don't