Re: [PATCH 09/11] pyjailhouse: config_parser: add missing components

2020-07-06 Thread Andrej Utz
On 05/07/2020 23:07, Jan Kiszka wrote: On 30.06.20 08:47, Andrej Utz wrote: They may not be used right now but will certainly ease the usage of the parser API in the future. Besides I already had written them long ago, so it would be a pity to withehld them. "withheld" Ack. While I under

Re: [PATCH 03/11] pyjailhouse: config_parser: consolidate binary parsing into CStruct class

2020-07-06 Thread Andrej Utz
On 05/07/2020 22:57, Jan Kiszka wrote: On 30.06.20 08:42, Andrej Utz wrote: The class slots define component fields in a more grounded way. This greatly simplifies definition of parseable compoments. The first `__slots__` tuple in each class defines a constant list of fields and also the corres

Re: [PATCH 01/11] pyjailhouse: config_parser: store binary format specification in struct.Struct

2020-07-06 Thread Andrej Utz
On 05/07/2020 22:55, Jan Kiszka wrote: On 30.06.20 08:42, Andrej Utz wrote: Improves its handling in the code and slightly increases the overall performance as well. Signed-off-by: Andrej Utz ---   pyjailhouse/config_parser.py | 51 ++--   1 file changed, 20 i

Re: [PATCH 01/11] pyjailhouse: config_parser: store binary format specification in struct.Struct

2020-07-06 Thread Andrej Utz
Hello Jan, thanks for reviewing. I will address the replies shortly. On 30/06/2020 21:12, Jan Kiszka wrote: On 30.06.20 08:42, Andrej Utz wrote: Improves its handling in the code and slightly increases the overall performance as well. Signed-off-by: Andrej Utz ---   pyjailhouse/config_parser