> One general question: I have not seen any @since and very few @version
> javadoc tags in the James code. Wouldn't it be useful? I tend to
> use it very
> consistently in my code.
Then use it here :-)
d.
Noel,
> > I'm wondering if the fake sender domain check done in Forward
> > should be shared by all the mailets.
>
> Possibly, but it should only be done if we are going to USE the Sender
> domain. If we are just forwarding the message from Postmaster,
> for example,
> we don't USE the original
To: James Developers List
Subject: [no virus] RE: New Redirect & sons becoming available
Noel,
> > I'm wondering if the fake sender domain check done in Forward
> > should be shared by all the mailets.
>
> Possibly, but it should only be done if we are going to USE the Sender
Vincenzo,
Committed. Please check commit message.
--- Noel
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Noel,
Three corrections to AbstractRedirect:
1) was (watch the "r\n\r\n" --> "\r\n\r\n")
new StringBuffer(1024)
.append(head)
.append("r\n\r\n")
.append(getMessageBody(messag
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18028
> I believe that the new code still has that problem. I've a tentative
> solution in mind that I'll post after committing your submission.
Not quite. The new code rendered it as:
Message:
[EMAIL PROTECTED]
Next up to try a fix.
Vincenzo,
In AbstractRedirect.buildAlteredMessage(Mail, Mail), shouldn't the two uses
of getAttachmentType() be getAttachmentType(originalMail)?
--- Noel
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional comman
Vincenzo,
I'll get it committed. In the meantime, would you please look at:
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18028
I believe that the new code still has that problem. I've a tentative
solution in mind that I'll post after committing your submission.
http://nagoya.apache.o
Noel,
I'm attaching the final (?) version of the new Redirect and other related mailets. I
have tested everything doing my best, but I suggest you and others to test it again.
The classes are:
AbstractRedirect
Forward extends AbstractRedirect
Redirect extends AbstractRedirect
AbstractNotify ext
Sending:
1) Correction to Redirect,
2) new NotifyPostmaster (not tested)
3) new Bounce (not tested, will still change something)
Vincenzo
NewRedirectAndSons.zip
Description: Macintosh archive
-
To unsubscribe, e-mail: [EMAIL PR
10 matches
Mail list logo
