RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-22 Thread Noel J. Bergman
> DNSSever block or implementation has returned a collection from the first > checkin on 2.5 years back. I know. I've pointed that out. The CVS lists Charles as the original entry, but see that there was some CVS re-org that must have lost even earlier changes. > If you ask my vote today, I'll

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-22 Thread Noel J. Bergman
Aaron, You missed it. He was making a joke. Hence the bike shed reference. --- Noel -- To unsubscribe, e-mail: For additional commands, e-mail:

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-22 Thread Harmeet Bedi
- Original Message - From: "Harmeet Bedi" <[EMAIL PROTECTED]> > I'll say Iterator as it can allow for MX Records > to be read on demand. Elaborating a bit more on why this may be a good idea - Usu. only one MX record is needed. Not sure why 2 would ever be needed if mail can be sent to the

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-22 Thread Harmeet Bedi
- Original Message - From: "Noel J. Bergman" <[EMAIL PROTECTED]> > Charles did the correct thing when he hid the implementation, and exposed > the narrow interface. Actually Serge choose Collection in the implementation, and I exposed it as the narrow interface. Charles improved the implem

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-22 Thread Noel J. Bergman
> I'm not proposing that the interface changes, I'd just like to paint the bike > shed *blue*. <> What color blue? <> --- Noel -- To unsubscribe, e-mail: For additional commands, e-mail:

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-22 Thread Noel J. Bergman
Aaron, > I agree with the unmodifiable collection thing. NOTE TO SERGEI: would you please put that in when you prepare the new submission? > I do like a good technical discussion, however! :-) If you want to continue this one, let's do everyone else a favor and take it off-list. I don't mind

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-22 Thread Darrell DeBoer
On Thu, 23 Jan 2003 07:47, [EMAIL PROTECTED] wrote:> > Bear in mind that I have agreed with several of your points. However, on > balance, it is my opinion that List - while not the idealistically perfect > solution - is the best compromise available. Grey lines again. Both you > and Serge have

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-22 Thread Noel J. Bergman
Serge, > I'm sorry you feel you had to write so much... What? You think that Stephen McConnell should have the exclusive on long messages? ;-) LOL I just walked through the steps, since there seemed to be disagreement. The simpler way to say it is just that List is a subset of Collection cla

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-22 Thread Serge Knystautas
Serge Knystautas wrote: Please let's just let this rest. There's no sense spending this much energy talking on this topic when there's code and documentation that everyone seems comfortable solving. And to follow that, a community where everyone agrees isn't feasible... (let's focus on where

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-22 Thread Serge Knystautas
Noel J. Bergman wrote: Again, if someone can demonstrate the List methods that embody this presumed contract, I'm happy to listen. The fact that we don't use methods other than those found on Collection belies the necessity, in my view. I'm sorry you feel you had to write so much... again I'm w

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-22 Thread Noel J. Bergman
OK, let me back this up to First Principles. We ought to be able to agree on the following points: 1. The semantic ordering required by RFC 2821 is mandatory. 2. The ordering is based upon any preference indicated by the MX record. 3. There may be more than one entry with the same pr

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-22 Thread alan.gerhard
> FWIW, > the day, returning a list provides a degree > of compile-time checking for adherence to our required > contract, returning a Collection does not. Sure, it > would be better still to have checking for the ordering > criteria too, but the cost/benefit ratio of providing > this does

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-22 Thread Aaron Knauf
FWIW, I agree with Serge on this one. Returning a List implies that the contents are ordered. (Which order is not specified, of course.) Returning a Collection does not imply that. Returning a SortedSet would imply that the contents are both ordered *and* that there are no duplicates. The cho

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-21 Thread Noel J. Bergman
> Ok, we just don't agree on this. We're not making any progress, so > let's just leave it as is. I'm sure we'll get there eventually. I agree that we're spending more cycles on this than it is worth right now. --- Noel -- To unsubscribe, e-mail: For addit

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-21 Thread Serge Knystautas
Noel J. Bergman wrote: I understand that you want a contract that tells the client that the collection is ordered. The catch is that there is nothing in the Java Collection classes that exposes any notion of semantic ordering other than Comparator. Ok, we just don't agree on this. We're not ma

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-21 Thread Noel J. Bergman
> > I understand, and I am all for meaningful contracts. My point is that a > > Java Collection is not unordered. It can be either ordered or unordered, > > based upon the implementation class. > Yes, this is my point... we should not leave it up to the implementation > as to whether it is order

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-21 Thread Steve Short
[EMAIL PROTECTED]] > Sent: Monday, January 20, 2003 8:51 PM > To: James Developers List > Subject: Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server > autodetect, Make use of higher level api > > > Steve Short wrote: > > You can use multiple MX records to the same IP

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-21 Thread Serge Knystautas
Noel J. Bergman wrote: If the question is whether the interface should change, there ought to be reasons. So far, I have not seen any was my point. Ok, I just meant that you can't reference the implementation if we're talking interfaces. I understand, and I am all for meaningful contracts. M

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-21 Thread Noel J. Bergman
> The question is whether the interface should change, and > you're talking about how the underlying implementation behaves. If the question is whether the interface should change, there ought to be reasons. So far, I have not seen any was my point. > The reason to change the interface is that M

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-20 Thread Serge Knystautas
Noel J. Bergman wrote: Change from Collection->List sounds good to me. Will go ahead and make this change in a day or two unless someone objects or gets to it sooner. The method returns a Collection of servers. At the time when we use the Collection, all that we can know, without changing

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-20 Thread Noel J. Bergman
> Change from Collection->List sounds good to me. Will go ahead and make this > change in a day or two unless someone objects or gets to it sooner. The method returns a Collection of servers. At the time when we use the Collection, all that we can know, without changing the content of the Collect

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-20 Thread Noel J. Bergman
> Sorry wasn't aware. I was concerned that your patch wasn't committed for a > few days and there was no conversation about it on the list. I don't know how you missed it. There were immediate replies to his post: http://nagoya.apache.org/eyebrowse/ReadMsg?[EMAIL PROTECTED] .org&msgNo=6756 http:

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-20 Thread Serge Knystautas
Steve Short wrote: You can use multiple MX records to the same IP to improve performance by allowing James to use multiple concurrent connections to the same mail server. IIRC Javamail has some per connection synchronisation and multiple MX records can be used to enable multiple connections. So

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-20 Thread Steve Short
> As for SortedSet vs. List, it logically makes more sense to > have it as a > SortedSet since it wouldn't make sense to have multiple MX records to > the same IP address. But you never know, I don't think DNS could > enforce this... I guess we just do extra checks as we add the IP > addresse

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-20 Thread Serge Knystautas
Harmeet Bedi wrote: At the moment Serge S's code is working so it does not impede anyone. I could roll it back or one could apply additional improvements that Serge S sends. Let me know if you prefer rollback. Yeah, I think it's functional and just has a design flaw (a static reference or somet

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-20 Thread Serge Knystautas
Serge Sozonoff wrote: Hi Aaron, The James DNSServer class has a custom Comparator and does the ordering. It returns an ordered list. Yeah, the DNSServer code uses a Vector as the underlying implementation and a custom comparator. Then all we really need to do is change the method contract to

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-20 Thread Aaron Knauf
January 20, 2003 12:02 AM Subject: Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api I completely agree with Serge with respect to list vs collection. His comments are, in fact, not open to disagreement. They are technical facts. However, I

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-20 Thread Serge Sozonoff
Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api > > I completely agree with Serge with respect to list vs collection. His > comments are, in fact, not open to disagreement. They are technical facts. > > However, I wonder if it might not

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-19 Thread Harmeet Bedi
[EMAIL PROTECTED]> To: "James Developers List" <[EMAIL PROTECTED]> Sent: Sunday, January 19, 2003 1:42 PM Subject: Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api > - Original Message - > From: "Harmeet Bedi"

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-19 Thread Harmeet Bedi
From: "Serge Knystautas" <[EMAIL PROTECTED]> > There was conversation on the list about it... the faults were pointed out > and (other) Serge said he would go fix and send revised changes. >.. > I don't think the library changes are in discussion. It's the code changes > that's in question. Sorry

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-19 Thread Serge Knystautas
- Original Message - From: "Harmeet Bedi" <[EMAIL PROTECTED]> > DNSServer block returs a sorted collection now and has been from the first > instance of the block. One could loose ordering in a collection but > converting to list does not help as list is a collection. Iterator may be > th

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-19 Thread Serge Knystautas
- Original Message - From: "Harmeet Bedi" <[EMAIL PROTECTED]> > From: "Serge Sozonoff" <[EMAIL PROTECTED]> > > Please hold off on the Commit of the DnsJava upgrade, I am still > > cleaning/clearing up a few things with Noel and we should have a new > version > > Sorry wasn't aware. I was

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-19 Thread Harmeet Bedi
From: "Serge Sozonoff" <[EMAIL PROTECTED]> > Please hold off on the Commit of the DnsJava upgrade, I am still > cleaning/clearing up a few things with Noel and we should have a new version Sorry wasn't aware. I was concerned that your patch wasn't committed for a few days and there was no conversa

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-19 Thread Serge Sozonoff
Too late.. Sergei - Original Message - From: "Serge Sozonoff" <[EMAIL PROTECTED]> To: "James Developers List" <[EMAIL PROTECTED]> Sent: Sunday, January 19, 2003 10:14 AM Subject: Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Mak

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-19 Thread Serge Sozonoff
suggesting that we remove the config option? Thanks, Sergei - Original Message - From: "Harmeet Bedi" <[EMAIL PROTECTED]> To: "James Developers List" <[EMAIL PROTECTED]> Sent: Saturday, January 18, 2003 8:22 PM Subject: Re: [PATCH] Upgrade to DnsJava 1.3.1,

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-18 Thread Harmeet Bedi
Original Message - From: "Serge Knystautas" <[EMAIL PROTECTED]> .. DNSServer API > > Are you saying it's returning a Collection right now? If it is, then it > should be returned as a List. MX records have an order, and if we put the > results in a Collection, it seems that we risk losing

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-18 Thread Serge Knystautas
- Original Message - From: "Harmeet Bedi" <[EMAIL PROTECTED]> > Looks good but a few minor things > - I don't think there is any need to change DNServer interface to return a > list instead of collection. The results obtained are already sorted > according to priority and there is no need

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-18 Thread Harmeet Bedi
Looks good but a few minor things - I don't think there is any need to change DNServer interface to return a list instead of collection. The results obtained are already sorted according to priority and there is no need to do any more sorting. The results returned are a collection of IP address so

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-17 Thread Danny Angus
> Go ahead and do it against the HEAD. If we decide to merge it into v2.1, > we'll worry about it then. :-) I'm running two instances of the HEAD one for my personal use and one for work, so I will be able to give you some independant (sort of) feedback. d. -- To unsubscribe, e-mail:

Re: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect,Make use of higher level api

2003-01-17 Thread Nicola Ken Barozzi
Noel J. Bergman wrote: Serge, Would you please revise your patch not to use the static dns class? The use of a static class in that fashion is OK for a standalone application, but I'd like to avoid that in a component architecture. There isn't a contractual guarantee that a component installe

RE: [PATCH] Upgrade to DnsJava 1.3.1, add DNS Server autodetect, Make use of higher level api

2003-01-16 Thread Noel J. Bergman
Serge, Would you please revise your patch not to use the static dns class? The use of a static class in that fashion is OK for a standalone application, but I'd like to avoid that in a component architecture. There isn't a contractual guarantee that a component installed by some admin might not