Re: [PATCH] jit: fix liveness analysis

2009-08-01 Thread Pekka Enberg
On Fri, 2009-07-31 at 18:12 +0200, Vegard Nossum wrote: > All registers that were defined in the basic block were subtracted from the > use set. This is right if the order is "define, use", but it's wrong if the > order is "use, define". Fix this by checking if the register has already > been used/

Re: [PATCH] jit: fix liveness analysis

2009-08-01 Thread Pekka Enberg
Hi Vegard, On Fri, 2009-07-31 at 18:12 +0200, Vegard Nossum wrote: > All registers that were defined in the basic block were subtracted from the > use set. This is right if the order is "define, use", but it's wrong if the > order is "use, define". Fix this by checking if the register has already

Re: [PATCH] vm: initialize monitor fields

2009-08-01 Thread Pekka Enberg
On Thu, 2009-07-30 at 14:41 +0200, Tomek Grabiec wrote: > Signed-off-by: Tomek Grabiec > --- > vm/object.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/vm/object.c b/vm/object.c > index cb69dca..1a5136a 100644 > --- a/vm/object.c > +++ b/vm/object.c > @@ -597,6

Re: [PATCH 4/6] vm: make static field fixup thread safe

2009-08-01 Thread Pekka Enberg
On Thu, 2009-07-30 at 12:50 +0200, Tomek Grabiec wrote: > diff --git a/include/vm/class.h b/include/vm/class.h > index 2ed5ffe..b827afc 100644 > --- a/include/vm/class.h > +++ b/include/vm/class.h > @@ -2,6 +2,7 @@ > #define _VM_CLASS_H > > #include > +#include > > #include "vm/field.h" >

Re: [PATCH 3/6] jato: prevent removal of .java regression test suite files on `make clean'

2009-08-01 Thread Pekka Enberg
On Thu, 2009-07-30 at 12:50 +0200, Tomek Grabiec wrote: > Signed-off-by: Tomek Grabiec > --- > Makefile |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index ede2d0c..c037fb8 100644 > --- a/Makefile > +++ b/Makefile > @@ -308,7 +308,6 @@ clean:

Re: [PATCH 1/6] jit: ensure tracing mutual exclusion during whole method compilation

2009-08-01 Thread Pekka Enberg
On Thu, 2009-07-30 at 12:50 +0200, Tomek Grabiec wrote: > We have to make trace_mutex recursive because java.lang.String > initialization might be triggered during compilation of method > containing ldc on String constant. > > Signed-off-by: Tomek Grabiec > +void init_tracing(void) > +{ > + p

Re: [RFC][PATCH] jit: fix handling of split intervals in register allocator

2009-08-01 Thread Pekka Enberg
On Wed, 2009-07-29 at 15:36 +0200, Tomek Grabiec wrote: > Liveness analysis can produce intervals with range not ending at a use > position. When splitting such interval after last use position we get > the new interval with non-zero range length and without use positions. > We should not add such