Hi Tomek,
On Tue, 2009-08-18 at 21:21 +0200, Tomek Grabiec wrote:
> Like I said on IRC, this will not work for empty basic blocks, because
> spill_at_insn will belong to the preceding
> basic block. This causes that instructions will be added to different
> (preceding) basic block and might not be
On Tue, 2009-08-18 at 21:21 +0200, Tomek Grabiec wrote:
> Like I said on IRC, this will not work for empty basic blocks, because
> spill_at_insn will belong to the preceding
> basic block. This causes that instructions will be added to different
> (preceding) basic block and might not be executed o
Branch: refs/heads/master
Home: http://github.com/penberg/jato
Commit: c8806ae78694b74be3c32aeae0fe4a7a2463ab84
http://github.com/penberg/jato/commit/c8806ae78694b74be3c32aeae0fe4a7a2463ab84
Author: Pekka Enberg
Date: 2009-08-17 (Mon, 17 Aug 2009)
Changed paths:
M jit/linear-scan.c
L
2009/8/18 Pekka Enberg :
> Lets use radix_tree_lookup() and get rid of the nasty loop in
> bb_last_insn(). For some reason, this seems to fix the infinite loop
> triggered by empty basic blocks.
>
> Cc: Arthur HUILLET
> Cc: Tomek Grabiec
> Signed-off-by: Pekka Enberg
> ---
> jit/basic-block.c
Use insn_is_branch() to determine whether we must insert a spill
instruction before or after the last instruction in a basic block.
Cc: Arthur HUILLET
Cc: Tomek Grabiec
Signed-off-by: Pekka Enberg
---
arch/mmix/include/arch/instruction.h |5 +
arch/x86/include/arch/instruction.h | 1
Lets use radix_tree_lookup() and get rid of the nasty loop in
bb_last_insn(). For some reason, this seems to fix the infinite loop
triggered by empty basic blocks.
Cc: Arthur HUILLET
Cc: Tomek Grabiec
Signed-off-by: Pekka Enberg
---
jit/basic-block.c | 16 +---
jit/spill-reload.
The 'pop_at_insn' argument is not used in insert_copy_slot_insn()
function so remove it to clean up code.
Cc: Arthur HUILLET
Cc: Tomek Grabiec
Signed-off-by: Pekka Enberg
---
jit/spill-reload.c | 13 +
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/jit/spill-reloa
Ack here as well, this is obviously correct (provided radix_tree_lookup()
works).
On Tue, 18 Aug 2009 21:41:19 +0300
Pekka Enberg wrote:
> Lets use radix_tree_lookup() and get rid of the nasty loop in
> bb_last_insn(). For some reason, this seems to fix the infinite loop
> triggered by empty ba
2009/8/17 Tomek Grabiec :
> 2009/8/17 Vegard Nossum :
>> BTW, which flags are those?
>>
>
> My patch sets flags the same way as jamvm (and hotspot) does:
> - for primitive types: ACC_PUBLIC + ACC_ABSTRACT + ACC_FINAL
> - for array types: ACC_ABSTRACT + ACC_FINAL + (flags for element class
> - ACC_I
