Re: svn commit: r180010 - in /lucene/java/trunk/src: java/org/apache/lucene/index/IndexReader.java java/org/apache/lucene/index/SegmentInfos.java test/org/apache/lucene/index/TestIndexReader.java

2005-06-07 Thread Daniel Naber
On Monday 06 June 2005 18:23, Bernhard Messer wrote: > i would suggest to remove the deprecated flags from methods > "getCurrentVersion()" and "lastModified()". Okay, I just did that and rephrased the javadoc so that lastModified should not be used to check whether a reader is up-to-date. Regar

FAQ entry about deletions

2005-06-07 Thread Daniel Naber
Hi, the FAQ contains this sentence: "Document that are deleted really are in deleted (???)" What is that supposed to mean? Could someone rephrase it? Regards Daniel -- http://www.danielnaber.de - To unsubscribe, e-mail: [EM

Re: svn-commit: 168449 FSDirectory

2005-06-07 Thread Chris Nokleberg
On Tue, 07 Jun 2005 09:13:10 +0200, Bernhard Messer wrote: > exactly, that's what i had in mind. I know that we have to allocate a > new string object for every call, but this must be much cheaper than the > current implementation which has to walk thru the whole array every time > the method is

Re: IndexFileNames

2005-06-07 Thread Doug Cutting
Bernhard Messer wrote: sorry for the confusion. On the first look, i thought the new class IndexFileNames, containing the necessary constant values, fits perfect into org.apache.lucene.index. After a more detailed look, i get the feeling that it would be much better to place the new class into

Re: IndexFileNames

2005-06-07 Thread Bernhard Messer
Bernhard Messer wrote: Doug Cutting wrote: [EMAIL PROTECTED] wrote: --- lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java (original) +++ lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java Mon Jun 6 10:52:12 2005 @@ -52,8 +52,8 @@ if (name.ends

Re: svn-commit: 168449 FSDirectory

2005-06-07 Thread Bernhard Messer
Doug Cutting wrote: Bernhard Messer wrote: Therefore i would like to propose two changes: 1) we should store the extension in a hash and not in String[] to have a faster lookup Do you mean to use something like: String lastDot = name.lastIndexOf('.'); if (lastDot >= 0) { String nameExt