[jira] Commented: (LUCENE-1390) add ISOLatinAccentFilter and deprecate ISOLatin1AccentFilter

2008-12-02 Thread Andi Vajda (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652694#action_12652694 ] Andi Vajda commented on LUCENE-1390: Could you please attach a patch for the change yo

[jira] Commented: (LUCENE-1390) add ISOLatinAccentFilter and deprecate ISOLatin1AccentFilter

2008-12-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652691#action_12652691 ] Robert Muir commented on LUCENE-1390: - I am using this patch and its working well. Ni

[jira] Commented: (LUCENE-1246) Missing a null check in BooleanQuery.toString(String)

2008-12-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652661#action_12652661 ] Mark Miller commented on LUCENE-1246: - I'm going to commit this unless anyone objects.

Re: [jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread John Wang
If you guys need help, maybe you guys should expand your committer list? "product speaks well for itself so far", from what I have heard, losta people are just branching off the code-base and making changes and do merges every release. I really don't want to do that here, but I am being forced down

Re: [jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Mark Miller
I worked on getting both of thoses issues resolved :) Sorry, can't please everyone. If it helps, I'll commit that second one soon now that I can. It's lazy consensus around here man. Mabye it's not ideal, but I think the product speaks well for itself so far. I've never met a more accomadat

Re: [jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread John Wang
I have described our use-case in good detail. I think it is a common architecture. And we are not using RemoteSearcher. This problem is not tied to RemoteSearcher, and we are not using RMI. Serialized java objects can be used at places other than RMI. "sometime you IMp serializable for RMI but you

[jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652599#action_12652599 ] Jason Rutherglen commented on LUCENE-1473: -- The Spring framework http://www.sprin

Re: [jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Mark Miller
Woah! I think you got the wrong impression. I think Doug said basically what I was thinking (if not a bit more clearly than I was thinking it). I think we are all open to any good patches. It's nice to understand and discuss them first though. To reiterate what doug mentioned, sometime you

[jira] Commented: (LUCENE-1470) Add TrieRangeQuery to contrib

2008-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652593#action_12652593 ] Michael McCandless commented on LUCENE-1470: bq. I asked for a good "benchmark

[jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread John Wang (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652594#action_12652594 ] John Wang commented on LUCENE-1473: --- the fact an object implements Serializable implies

[jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652591#action_12652591 ] Doug Cutting commented on LUCENE-1473: -- The attached patch optimizes java serializati

[jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652585#action_12652585 ] Jason Rutherglen commented on LUCENE-1473: -- Currently serialization between 2.3 a

[jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652580#action_12652580 ] Mark Miller commented on LUCENE-1473: - bq. Lucene supports serialization explicitly by

[jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652576#action_12652576 ] Michael McCandless commented on LUCENE-1473: bq. The serialVersionUID needs to

[jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652572#action_12652572 ] Jason Rutherglen commented on LUCENE-1473: -- Lucene supports serialization explici

[jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652569#action_12652569 ] Mark Miller commented on LUCENE-1473: - I share Michaels concerns. Whats the motivation

[jira] Resolved: (LUCENE-1474) Incorrect SegmentInfo.delCount when IndexReader.flush() is used

2008-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-1474. Resolution: Fixed Fix Version/s: 2.9 Committed revision 722645. Thanks Mar

[jira] Updated: (LUCENE-1344) Make the Lucene jar an OSGi bundle

2008-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1344: --- Priority: Minor (was: Major) Lucene Fields: [New, Patch Available] (was: [

[jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652555#action_12652555 ] Jason Rutherglen commented on LUCENE-1473: -- The serialVersionUID needs to be writ

[jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652546#action_12652546 ] Michael McCandless commented on LUCENE-1473: Do we really need to write the se

[jira] Commented: (LUCENE-1474) Incorrect SegmentInfo.delCount when IndexReader.flush() is used

2008-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652527#action_12652527 ] Michael McCandless commented on LUCENE-1474: Good catch! Great test case... t

[jira] Assigned: (LUCENE-1474) Incorrect SegmentInfo.delCount when IndexReader.flush() is used

2008-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reassigned LUCENE-1474: -- Assignee: Michael McCandless > Incorrect SegmentInfo.delCount when IndexReader

[jira] Updated: (LUCENE-1474) Incorrect SegmentInfo.delCount when IndexReader.flush() is used

2008-12-02 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated LUCENE-1474: - Attachment: IndexReaderTest.java Test case to reproduce issue. > Incorrect SegmentInfo.

[jira] Created: (LUCENE-1474) Incorrect SegmentInfo.delCount when IndexReader.flush() is used

2008-12-02 Thread Marcel Reutegger (JIRA)
Incorrect SegmentInfo.delCount when IndexReader.flush() is used --- Key: LUCENE-1474 URL: https://issues.apache.org/jira/browse/LUCENE-1474 Project: Lucene - Java Issue Type: Bug

Re: InstantiatedIndexWriter

2008-12-02 Thread Jason Rutherglen
When will we need the tokenstream functionality changed by? I browsed the existing IndexWriter code and there is DocInverterPerThread.BackwardsCompatibilityStream. Where in the existing code are the Attributes used when analyzing? Which analyzers and tokenizers use the new Attribute Tokenizer me

[jira] Commented: (LUCENE-1470) Add TrieRangeQuery to contrib

2008-12-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652413#action_12652413 ] Uwe Schindler commented on LUCENE-1470: --- >From my point of view: the patch is now re

[jira] Updated: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated LUCENE-1473: - Attachment: LUCENE-1473.patch LUCENE-1473.patch Term implements Externalizable. Added

[jira] Created: (LUCENE-1473) Implement Externalizable in main top level searcher classes

2008-12-02 Thread Jason Rutherglen (JIRA)
Implement Externalizable in main top level searcher classes --- Key: LUCENE-1473 URL: https://issues.apache.org/jira/browse/LUCENE-1473 Project: Lucene - Java Issue Type: Bug

[jira] Updated: (LUCENE-1470) Add TrieRangeQuery to contrib

2008-12-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1470: -- Attachment: LUCENE-1470.patch New version of the patch: - moved default trie variant handling

[jira] Commented: (LUCENE-1470) Add TrieRangeQuery to contrib

2008-12-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652348#action_12652348 ] Uwe Schindler commented on LUCENE-1470: --- It is almost complete. In my opinion the on

Re: [PATCH] Bug on BrazilianAnalyzer

2008-12-02 Thread Michael McCandless
Rafael, Could you work these changes into a patch, add a test case, and open a Jira issue? Maybe first make the simple fixes (removing final, moving LowerCaseFilter up in the chain), and then as a 2nd issue this deeper refactoring of all StemFilters? Thanks. I agree the original issue

[jira] Updated: (LUCENE-1468) FSDirectory.list() is inconsistent

2008-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1468: --- Attachment: LUCENE-1468.patch Attached patch. I think it's ready to commit. I'll

[jira] Commented: (LUCENE-1470) Add TrieRangeQuery to contrib

2008-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652344#action_12652344 ] Michael McCandless commented on LUCENE-1470: Uwe, is this ready to be committe

[jira] Commented: (LUCENE-1472) DateTools.stringToDate() can cause lock contention under load

2008-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652336#action_12652336 ] Michael McCandless commented on LUCENE-1472: I agree: ThreadLocal, despite its