RE: ReadOnly IndexReaders

2009-05-30 Thread Uwe Schindler
I see no problem adding these three lines for an accessor to IndexReader! +1 - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de -Original Message- From: Grant Ingersoll [mailto:gsing...@apache.org] Sent: Friday, May 29, 2009 11:21

[jira] Assigned: (LUCENE-1542) Lucene can incorrectly set the position of tokens that start a field with positonInc 0.

2009-05-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reassigned LUCENE-1542: -- Assignee: Michael McCandless Lucene can incorrectly set the position of

[jira] Commented: (LUCENE-1542) Lucene can incorrectly set the position of tokens that start a field with positonInc 0.

2009-05-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12714684#action_12714684 ] Michael McCandless commented on LUCENE-1542: OK I plan to commit the current

[jira] Resolved: (LUCENE-1542) Lucene can incorrectly set the position of tokens that start a field with positonInc 0.

2009-05-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-1542. Resolution: Fixed Lucene can incorrectly set the position of tokens that start a

Re: Lucene's default settings back compatibility

2009-05-30 Thread Earwin Burrfoot
As far as I understand the policy-making process, someone from PMC has to start the vote, and then PMC members should, well, vote. Without them taking action we can beep to our hearts' content without any consequences. On Sat, May 30, 2009 at 07:22, Shai Erera ser...@gmail.com wrote: So ... I've

[jira] Resolved: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory

2009-05-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-1658. Resolution: Fixed Absorb NIOFSDirectory into FSDirectory

Re: Lucene's default settings back compatibility

2009-05-30 Thread Grant Ingersoll
I think the last piece that is needed is to ask on java-user what others think. In order to do that, I think it needs to be boiled down to a couple paragraphs. -Grant On May 29, 2009, at 11:22 PM, Shai Erera wrote: So ... I've this happen a lot of times (especially in my thesis work) -

Re: Lucene's default settings back compatibility

2009-05-30 Thread Michael McCandless
Actually, I think this is a common, and in fact natural/expected occurrence in open-source. When a tricky topic is discussed, and the opinions are often divergent, frequently the conversation never converges to a consensus and the discussion dies. Only if discussion reaches a semblance of

Re: Lucene's default settings back compatibility

2009-05-30 Thread DM Smith
I think one conclusion that did come of this discussion was that bugs should be fixed even if it breaks backward compatibility. -- DM On May 30, 2009, at 7:21 AM, Michael McCandless wrote: Actually, I think this is a common, and in fact natural/expected occurrence in open-source. When a

Re: Lucene's default settings back compatibility

2009-05-30 Thread Shai Erera
Ok, so digging back in this thread, I think the following proposals were made (if I missed some, please add them): 1. API deprecation last *at least* one full minor release. Example: if we deprecate an API in 2.4, we can remove it in 2.5. BUT, we are also free to keep it there and remove it in

Re: ReadOnly IndexReaders

2009-05-30 Thread Michael McCandless
Makes sense! Mike On Fri, May 29, 2009 at 5:21 PM, Grant Ingersoll gsing...@apache.org wrote: Does it make sense to add isReadOnly() to IndexReader such that one can easily introspect whether a Reader is read only? -Grant

Re: ReadOnly IndexReaders

2009-05-30 Thread Grant Ingersoll
OK, I'll do it. On May 30, 2009, at 8:29 AM, Michael McCandless wrote: Makes sense! Mike On Fri, May 29, 2009 at 5:21 PM, Grant Ingersoll gsing...@apache.org wrote: Does it make sense to add isReadOnly() to IndexReader such that one can easily introspect whether a Reader is read only?

Re: ReadOnly IndexReaders

2009-05-30 Thread Mark Miller
Is there a valid use case? It seems like it might be a tricky method, because its an IndexReader property and not the index. A user should probably technically treat read-only/non-read-only the same because it does not imply a different IndexReader didn't make changes/do deletes? It doesn't

Re: ReadOnly IndexReaders

2009-05-30 Thread Yonik Seeley
On Sat, May 30, 2009 at 1:27 PM, Mark Miller markrmil...@gmail.com wrote: Is there a valid use case? That was my question too... I really can't think of one. Maybe we should leave it out until there is actually a need for it. -Yonik http://www.lucidimagination.com

Re: ReadOnly IndexReaders

2009-05-30 Thread Simon Willnauer
+1 On May 29, 2009 11:27 PM, Jason Rutherglen jason.rutherg...@gmail.com wrote: Yeah! On Fri, May 29, 2009 at 2:21 PM, Grant Ingersoll gsing...@apache.org wrote: Does it make sen...

[jira] Commented: (LUCENE-1614) Add next() and skipTo() variants to DocIdSetIterator that return the current doc, instead of boolean

2009-05-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12714762#action_12714762 ] Shai Erera commented on LUCENE-1614: I was wondering if instead of adding an assert to

[jira] Created: (LUCENE-1668) Trunk fails tests, FSD.open() - related

2009-05-30 Thread Earwin Burrfoot (JIRA)
Trunk fails tests, FSD.open() - related --- Key: LUCENE-1668 URL: https://issues.apache.org/jira/browse/LUCENE-1668 Project: Lucene - Java Issue Type: Bug Environment: MacOS 10.6, Java 1.6 64bit

[jira] Commented: (LUCENE-1668) Trunk fails tests, FSD.open() - related

2009-05-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12714781#action_12714781 ] Uwe Schindler commented on LUCENE-1668: --- The whole LUCENE-1658 has more problems and

[jira] Reopened: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory

2009-05-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reopened LUCENE-1658: --- This issue has some more problems after committing. And there are also inconsistencies. I am

[jira] Assigned: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory

2009-05-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-1658: - Assignee: Uwe Schindler (was: Michael McCandless) Absorb NIOFSDirectory into

[jira] Reopened: (LUCENE-1453) When reopen returns a new IndexReader, both IndexReaders may now control the lifecycle of the underlying Directory which is managed by reference counting

2009-05-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reopened LUCENE-1453: --- Is this patch obsolete, if LUCENE-1658 is correctly resolved and the whole caching from FSDir

[jira] Commented: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory

2009-05-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12714790#action_12714790 ] Uwe Schindler commented on LUCENE-1658: --- This issue breaks some platforms (if

[jira] Issue Comment Edited: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory

2009-05-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12714793#action_12714793 ] Uwe Schindler edited comment on LUCENE-1658 at 5/30/09 4:40 PM:

[jira] Updated: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory

2009-05-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1658: -- Attachment: LUCENE-1658-take2.patch This is a revised patch (on current trunk): -

[jira] Commented: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory

2009-05-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12714795#action_12714795 ] Uwe Schindler commented on LUCENE-1658: --- One comment: The part with the reflection

[jira] Updated: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory

2009-05-30 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-1658: -- Attachment: LUCENE-1658-take2.patch New patch: Now only TestCompoundFile fails, some more

Axing contrib-similarity

2009-05-30 Thread Otis Gospodnetic
Hi, I just stumbled upon: http://repo1.maven.org/maven2/org/apache/lucene/lucene-similarity/ Nothing since 2.2.0?! Well, it looks like there really is nothing in contrib/similarity (the SweetSpotSimilarity is in contrib/miscellaneous): similarity |-- README.txt |-- build.xml |--