[jira] Commented: (LUCENE-2392) Enable flexible scoring

2010-04-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855802#action_12855802 ] Robert Muir commented on LUCENE-2392: - Mike, I don't think overlapTermCount should rea

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Earwin Burrfoot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855793#action_12855793 ] Earwin Burrfoot commented on LUCENE-2386: - The mode in ctor is perfectly fine. Rem

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855792#action_12855792 ] Uwe Schindler commented on LUCENE-2386: --- Thanks Earwin, thats exactly my opinion, to

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Earwin Burrfoot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855791#action_12855791 ] Earwin Burrfoot commented on LUCENE-2386: - I don't see why this should be "fixed".

[jira] Commented: (LUCENE-2316) Define clear semantics for Directory.fileLength

2010-04-11 Thread Earwin Burrfoot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855787#action_12855787 ] Earwin Burrfoot commented on LUCENE-2316: - I like Marvin's suggestion - deprecate/

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855786#action_12855786 ] Michael McCandless commented on LUCENE-2386: Patch looks good... thanks Shai.

[jira] Updated: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2386: --- Attachment: LUCENE-2386.patch Patch w/ proposed fixes. All tests pass, including Solr's :). > Index

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855767#action_12855767 ] Shai Erera commented on LUCENE-2386: About IndexReader.listCommits ... the javadocs st

[jira] Updated: (LUCENE-2392) Enable flexible scoring

2010-04-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-2392: --- Attachment: LUCENE-2392.patch Rough first patch attached > Enable flexible scor

[jira] Created: (LUCENE-2392) Enable flexible scoring

2010-04-11 Thread Michael McCandless (JIRA)
Enable flexible scoring --- Key: LUCENE-2392 URL: https://issues.apache.org/jira/browse/LUCENE-2392 Project: Lucene - Java Issue Type: Improvement Components: Search Reporter: Michael McCandless

[jira] Created: (LUCENE-2391) Spellchecker uses default IW mergefactor/ramMB settings of 300/10

2010-04-11 Thread Mark Miller (JIRA)
Spellchecker uses default IW mergefactor/ramMB settings of 300/10 - Key: LUCENE-2391 URL: https://issues.apache.org/jira/browse/LUCENE-2391 Project: Lucene - Java Issue Type: Im

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855752#action_12855752 ] Yonik Seeley commented on LUCENE-2386: -- I think Solr's spellchecker should be OK. It

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855750#action_12855750 ] Michael McCandless commented on LUCENE-2386: Shai I think you should also chec

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855748#action_12855748 ] Mark Miller commented on LUCENE-2386: - bq. Hmmm... I think the back compat break is ve

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855747#action_12855747 ] Michael McCandless commented on LUCENE-2386: Actually I consider this a bug in

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855740#action_12855740 ] Mark Miller commented on LUCENE-2386: - {quote}I do think this is a good change - IW wa

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855739#action_12855739 ] Uwe Schindler commented on LUCENE-2386: --- I dont understand the whole issue, too. Fo

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855738#action_12855738 ] Michael McCandless commented on LUCENE-2386: I like the fix (catching the NoSu

[jira] Commented: (LUCENE-2316) Define clear semantics for Directory.fileLength

2010-04-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855736#action_12855736 ] Michael McCandless commented on LUCENE-2316: I don't think Lucene relies on fi

[jira] Updated: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2386: --- Attachment: LUCENE-2386.patch Fixes IndexFileDeleter, adds a proper test to TestIndexWriter. Haven't

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855732#action_12855732 ] Mark Miller commented on LUCENE-2386: - Is this change worth it with all of its repercu

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855727#action_12855727 ] Shai Erera commented on LUCENE-2386: Committed revision 932917 for the revert. > Inde

[jira] Reopened: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera reopened LUCENE-2386: As I indicated in an email, Solr tests failed (sorry for not running them before). After some investi

[jira] Updated: (LUCENE-2154) Need a clean way for Dir/MultiReader to "merge" the AttributeSources of the sub-readers

2010-04-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-2154: -- Attachment: LUCENE-2154-Jakarta-BCEL.patch Slightly improved patch to correctly work with Char

Re: svn commit: r932873 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexNotFoundException.java

2010-04-11 Thread Shai Erera
Sorry about that ... On Sun, Apr 11, 2010 at 3:10 PM, wrote: > Author: uschindler > Date: Sun Apr 11 12:10:57 2010 > New Revision: 932873 > > URL: http://svn.apache.org/viewvc?rev=932873&view=rev > Log: > add missing license header > > Modified: > > > lucene/dev/trunk/lucene/src/java/org/apach

[jira] Commented: (LUCENE-1709) Parallelize Tests

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855713#action_12855713 ] Shai Erera commented on LUCENE-1709: Committed revision 932878 with the following: # b

[jira] Resolved: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-2386. Lucene Fields: [New, Patch Available] (was: [New]) Resolution: Fixed Committed revision 93

[jira] Resolved: (LUCENE-2389) Enforce TokenStream impl / Analyzer finalness by an assertion

2010-04-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-2389. --- Resolution: Fixed Committed revision: 932864 > Enforce TokenStream impl / Analyzer finalnes

[jira] Commented: (LUCENE-1709) Parallelize Tests

2010-04-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855700#action_12855700 ] Robert Muir commented on LUCENE-1709: - I committed the junit tempdir fix in revision 9

RE: svn commit: r932773 - /lucene/dev/trunk/solr/src/test/org/apache/solr/analysis/TestLuceneMatchVersion.java

2010-04-11 Thread Uwe Schindler
This is why i added the comment. But I forgot about it when I committed the lucene refactoring J So lets fix it with a simple getter! - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de From: Robert Muir [ma

Re: svn commit: r932773 - /lucene/dev/trunk/solr/src/test/org/apache/solr/analysis/TestLuceneMatchVersion.java

2010-04-11 Thread Robert Muir
I agree we should do something better, I do not like the way the test looks now (no offense) as it is prone to break... On Sun, Apr 11, 2010 at 5:39 AM, Uwe Schindler wrote: > Robert, > > as the comment says, it’s a hack. How about simply adding a public getter > method for the matchVersion to

RE: svn commit: r932773 - /lucene/dev/trunk/solr/src/test/org/apache/solr/analysis/TestLuceneMatchVersion.java

2010-04-11 Thread Uwe Schindler
Robert, as the comment says, it’s a hack. How about simply adding a public getter method for the matchVersion to the base class StopwordAwareAna? Uwe - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: r

[jira] Resolved: (LUCENE-2358) rename KeywordMarkerTokenFilter

2010-04-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-2358. - Resolution: Fixed Committed revision 932856. > rename KeywordMarkerTokenFilter > --

[jira] Assigned: (LUCENE-2358) rename KeywordMarkerTokenFilter

2010-04-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reassigned LUCENE-2358: --- Assignee: Robert Muir > rename KeywordMarkerTokenFilter > --- >