[jira] Commented: (LUCENE-2324) Per thread DocumentsWriters that write their own private segments

[ https://issues.apache.org/jira/browse/LUCENE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857385#action_12857385 ] Tim Smith commented on LUCENE-2324: --- bq. Probably if you really want to keep

[jira] Commented: (LUCENE-2324) Per thread DocumentsWriters that write their own private segments

[ https://issues.apache.org/jira/browse/LUCENE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857375#action_12857375 ] Tim Smith commented on LUCENE-2324: --- bq. But... could we allow an add/updateDocu

[jira] Commented: (LUCENE-2071) Allow updating of IndexWriter SegmentReaders

[ https://issues.apache.org/jira/browse/LUCENE-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851528#action_12851528 ] Tim Smith commented on LUCENE-2071: --- found a couple of small issues with the p

[jira] Commented: (LUCENE-2071) Allow updating of IndexWriter SegmentReaders

[ https://issues.apache.org/jira/browse/LUCENE-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851388#action_12851388 ] Tim Smith commented on LUCENE-2071: --- +1 I have a special subclassed IndexSearcher

[jira] Commented: (LUCENE-2345) Make it possible to subclass SegmentReader

[ https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850361#action_12850361 ] Tim Smith commented on LUCENE-2345: --- bq. My patch removes loadTermsIndex method

[jira] Commented: (LUCENE-2345) Make it possible to subclass SegmentReader

[ https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850323#action_12850323 ] Tim Smith commented on LUCENE-2345: --- found one issue with the plugins patch With

[jira] Updated: (LUCENE-2345) Make it possible to subclass SegmentReader

[ https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Smith updated LUCENE-2345: -- Attachment: LUCENE-2345_3.0.plugins.patch Here's a patch (again, against 3.0) showing the minima

[jira] Commented: (LUCENE-2345) Make it possible to subclass SegmentReader

[ https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850127#action_12850127 ] Tim Smith commented on LUCENE-2345: --- bq. I think we should only commit this only on

[jira] Commented: (LUCENE-2345) Make it possible to subclass SegmentReader

[ https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849731#action_12849731 ] Tim Smith commented on LUCENE-2345: --- that was my plan > Make it possible to s

[jira] Updated: (LUCENE-2345) Make it possible to subclass SegmentReader

[ https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Smith updated LUCENE-2345: -- Attachment: LUCENE-2345_3.0.patch Here's a patch against 3.0 that provides the SegmentReaderFa

[jira] Commented: (LUCENE-2345) Make it possible to subclass SegmentReader

[ https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849497#action_12849497 ] Tim Smith commented on LUCENE-2345: --- i'll do my initial work on 3.0 so i can a

[jira] Commented: (LUCENE-2345) Make it possible to subclass SegmentReader

[ https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849455#action_12849455 ] Tim Smith commented on LUCENE-2345: --- that's the reassurance i needed :) w

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849358#action_12849358 ] Tim Smith commented on LUCENE-1821: --- This would actually be solved by LUCENE-2345

[jira] Created: (LUCENE-2345) Make it possible to subclass SegmentReader

Reporter: Tim Smith Fix For: 3.1 I would like the ability to subclass SegmentReader for numerous reasons: * to capture initialization/close events * attach custom objects to an instance of a segment reader (caches, statistics, so on and so forth) * override methods on segment reader as

[jira] Commented: (LUCENE-2310) Reduce Fieldable, AbstractField and Field complexity

[ https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844930#action_12844930 ] Tim Smith commented on LUCENE-2310: --- Personally, i like keeping Fieldable, (or ha

[jira] Commented: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

[ https://issues.apache.org/jira/browse/LUCENE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839682#action_12839682 ] Tim Smith commented on LUCENE-2283: --- i haven't been able to fully replicate t

[jira] Updated: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

[ https://issues.apache.org/jira/browse/LUCENE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Smith updated LUCENE-2283: -- Attachment: LUCENE-2283.patch Here's a new patch with your suggestions > Possible Memory

[jira] Commented: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

[ https://issues.apache.org/jira/browse/LUCENE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838976#action_12838976 ] Tim Smith commented on LUCENE-2283: --- I'll work up another patch might take

Re: Stored fields access

ument. > To add insult to injury, Document and Fieldable define a boatload of > stuff that is used at indexation-time, but has zero meaning at > search-time. > This is just broken, quickly-hacked-together API. > > 2010/2/25 Tim Smith : > >> I created LUCENE-2276 a coup

Re: Stored fields access

I created LUCENE-2276 a couple of days ago to at least allow reusing Document objects (didn't see any interest from anyone though) -- Tim Erick Erickson wrote: > OK, never mind > > Erick > > On Thu, Feb 25, 2010 at 1:48 PM, Earwin Burrfoot > wrote: > > My issu

[jira] Updated: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

[ https://issues.apache.org/jira/browse/LUCENE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Smith updated LUCENE-2283: -- Attachment: LUCENE-2283.patch Here's a patch for using a pool for stored fields buffers >

[jira] Commented: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

[ https://issues.apache.org/jira/browse/LUCENE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838017#action_12838017 ] Tim Smith commented on LUCENE-2283: --- i'm working up a patch for the shared

[jira] Commented: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

[ https://issues.apache.org/jira/browse/LUCENE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837919#action_12837919 ] Tim Smith commented on LUCENE-2283: --- another note is that this was on 64 bit vm

[jira] Commented: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

[ https://issues.apache.org/jira/browse/LUCENE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837881#action_12837881 ] Tim Smith commented on LUCENE-2283: --- latest profile dump has pointed out a non-lu

[jira] Commented: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

[ https://issues.apache.org/jira/browse/LUCENE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837875#action_12837875 ] Tim Smith commented on LUCENE-2283: --- bq. I agree. I'll mull over how to do it.

[jira] Commented: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

[ https://issues.apache.org/jira/browse/LUCENE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837821#action_12837821 ] Tim Smith commented on LUCENE-2283: --- ramBufferSizeMB is 64MB Here's th

[jira] Commented: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

[ https://issues.apache.org/jira/browse/LUCENE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837793#action_12837793 ] Tim Smith commented on LUCENE-2283: --- I came across this issue looking for a repo

[jira] Created: (LUCENE-2283) Possible Memory Leak in StoredFieldsWriter

Reporter: Tim Smith StoredFieldsWriter creates a pool of PerDoc instances this pool will grow but never be reclaimed by any mechanism furthermore, each PerDoc instance contains a RAMFile. this RAMFile will also never be truncated (and will only ever grow) (as far as i can tell) When feeding

[jira] Created: (LUCENE-2276) Add IndexReader.document(int, Document, FieldSelector)

Components: Search Reporter: Tim Smith The Document object passed in would be populated with the fields identified by the FieldSelector for the specified internal document id This method would allow reuse of Document objects when retrieving stored fields from the index -- This message

[jira] Commented: (LUCENE-1923) Add toString() or getName() method to IndexReader

[ https://issues.apache.org/jira/browse/LUCENE-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790803#action_12790803 ] Tim Smith commented on LUCENE-1923: --- added getName() in case anyone is curre

[jira] Updated: (LUCENE-1923) Add toString() or getName() method to IndexReader

[ https://issues.apache.org/jira/browse/LUCENE-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Smith updated LUCENE-1923: -- Attachment: LUCENE-1923.patch Here's a simple patch to get the ball rolling This adds a &qu

[jira] Commented: (LUCENE-1923) Add toString() or getName() method to IndexReader

[ https://issues.apache.org/jira/browse/LUCENE-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787472#action_12787472 ] Tim Smith commented on LUCENE-1923: --- i won't have the time till after the new

[jira] Commented: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

[ https://issues.apache.org/jira/browse/LUCENE-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786921#action_12786921 ] Tim Smith commented on LUCENE-1859: --- close if you like application writers can

[jira] Commented: (LUCENE-2086) When resolving deletes, IW should resolve in term sort order

[ https://issues.apache.org/jira/browse/LUCENE-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781615#action_12781615 ] Tim Smith commented on LUCENE-2086: --- Got some performance numbers: Description of

[jira] Commented: (LUCENE-2086) When resolving deletes, IW should resolve in term sort order

[ https://issues.apache.org/jira/browse/LUCENE-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780710#action_12780710 ] Tim Smith commented on LUCENE-2086: --- bq. maybe try it & report back? i'll

[jira] Commented: (LUCENE-2086) When resolving deletes, IW should resolve in term sort order

[ https://issues.apache.org/jira/browse/LUCENE-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780701#action_12780701 ] Tim Smith commented on LUCENE-2086: --- i've seen the deletes dominating commit t

[jira] Commented: (LUCENE-2086) When resolving deletes, IW should resolve in term sort order

[ https://issues.apache.org/jira/browse/LUCENE-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780698#action_12780698 ] Tim Smith commented on LUCENE-2086: --- any chance this can go into 3.0.0 or a 3

[jira] Commented: (LUCENE-1909) Make IndexReader.DEFAULT_TERMS_INDEX_DIVISOR public

[ https://issues.apache.org/jira/browse/LUCENE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777136#action_12777136 ] Tim Smith commented on LUCENE-1909: --- bq. If you want to inherit the setting, use

[jira] Commented: (LUCENE-1909) Make IndexReader.DEFAULT_TERMS_INDEX_DIVISOR public

[ https://issues.apache.org/jira/browse/LUCENE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777118#action_12777118 ] Tim Smith commented on LUCENE-1909: --- Only thing i would want the constant for i

[jira] Commented: (LUCENE-1909) Make IndexReader.DEFAULT_TERMS_INDEX_DIVISOR public

[ https://issues.apache.org/jira/browse/LUCENE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777109#action_12777109 ] Tim Smith commented on LUCENE-1909: --- what you describe requires effectively 2 sett

[jira] Commented: (LUCENE-1909) Make IndexReader.DEFAULT_TERMS_INDEX_DIVISOR public

[ https://issues.apache.org/jira/browse/LUCENE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777064#action_12777064 ] Tim Smith commented on LUCENE-1909: --- users can see the live setting via things like

[jira] Commented: (LUCENE-1909) Make IndexReader.DEFAULT_TERMS_INDEX_DIVISOR public

[ https://issues.apache.org/jira/browse/LUCENE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777008#action_12777008 ] Tim Smith commented on LUCENE-1909: --- I have the following use case: i ha

Re: The Release of Lucene 2.9

see if I can figure it out. >>> I had some issues copying this stuff that Grant was helping me out >>> with - but I think we missed that there was still an issue with core >>> and instantiated. >>> >>> Thanks Tim. >>> >>> Tim Smith wrot

Re: The Release of Lucene 2.9

Looks like the maven artifacts for lucene-core for 2.9.0 weren't pushed to the maven repo: http://repo1.maven.org/maven2/org/apache/lucene/lucene-core/ lucene instantiated also looks to be missing 2.9.0 artifacts: http://repo1.maven.org/maven2/org/apache/lucene/lucene-instantiated/ -- Tim Mark

[jira] Commented: (LUCENE-1925) In IndexSearcher class, make subReader and docCount arrays protected so sub classes can access them

[ https://issues.apache.org/jira/browse/LUCENE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759111#action_12759111 ] Tim Smith commented on LUCENE-1925: --- i would also like to see a protected constru

[jira] Commented: (LUCENE-1923) Add toString() or getName() method to IndexReader

[ https://issues.apache.org/jira/browse/LUCENE-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758717#action_12758717 ] Tim Smith commented on LUCENE-1923: --- I'll work up a patch that will do the

[jira] Created: (LUCENE-1923) Add toString() or getName() method to IndexReader

Reporter: Tim Smith It would be very useful for debugging if IndexReader either had a getName() method, or a toString() implementation that would get a string identification for the reader. for SegmentReader, this would return the same as getSegmentName() for Directory readers, this

Re: How to leverage the LogMergePolicy "calibrateSizeByDeletes" patch in Solr ?

d be available?) OneMerge looks heavily package private as well -- Tim > On Tue, Sep 22, 2009 at 11:43 AM, Tim Smith wrote: > >> Jason Rutherglen wrote: >> >> I have a working version of Simple FieldCache Merging LUCENE-1785 that >> should go in real soon. >&g

Re: How to leverage the LogMergePolicy "calibrateSizeByDeletes" patch in Solr ?

t; >> 2. See Lucene-831 - I think we will get some form of that in someday. >> >> Tim Smith wrote: >> >>> This sounds pretty interesting >>> >>> is there a proposed API for doing this warming yet? >>> Is there a ticket tracking this?

Re: How to leverage the LogMergePolicy "calibrateSizeByDeletes" patch in Solr ?

uot;IndexCache" object, instead of using static weak reference hash maps. (could then add methods like getFieldCache() to the IndexReader) -- Tim Smith Michael McCandless wrote: > Well described, that's exactly it! I like the concrete example :) > > Thanks Yonik. > >

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757199#action_12757199 ] Tim Smith commented on LUCENE-1821: --- I've been playing with per-segment cache

[jira] Created: (LUCENE-1915) Add static openInput(File,...) methods to all FSDirectory implementations

Issue Type: Wish Components: Store Reporter: Tim Smith It would be really useful if NIOFSDirectory and MMapDirectory had static methods for opening an input for arbitrary Files SimpleFSDirectory should likewise have a static openInput(File) method in order to cover all

[jira] Commented: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

[ https://issues.apache.org/jira/browse/LUCENE-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748122#action_12748122 ] Tim Smith commented on LUCENE-1859: --- On documentation: any warnings/precautions sh

[jira] Commented: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

[ https://issues.apache.org/jira/browse/LUCENE-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748103#action_12748103 ] Tim Smith commented on LUCENE-1859: --- bq. Death by a thousand cuts. This is one cut.

[jira] Issue Comment Edited: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

[ https://issues.apache.org/jira/browse/LUCENE-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748091#action_12748091 ] Tim Smith edited comment on LUCENE-1859 at 8/26/09 12:1

[jira] Commented: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

[ https://issues.apache.org/jira/browse/LUCENE-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748091#action_12748091 ] Tim Smith commented on LUCENE-1859: --- i fail to see the complexity of adding one me

[jira] Commented: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

[ https://issues.apache.org/jira/browse/LUCENE-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748082#action_12748082 ] Tim Smith commented on LUCENE-1859: --- bq. which non-intelligent tokenizers are

[jira] Commented: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

[ https://issues.apache.org/jira/browse/LUCENE-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748077#action_12748077 ] Tim Smith commented on LUCENE-1859: --- bq. I would set this to minor and would not

[jira] Issue Comment Edited: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

[ https://issues.apache.org/jira/browse/LUCENE-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748071#action_12748071 ] Tim Smith edited comment on LUCENE-1859 at 8/26/09 11:3

[jira] Commented: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

[ https://issues.apache.org/jira/browse/LUCENE-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748071#action_12748071 ] Tim Smith commented on LUCENE-1859: --- b1. The worst-case scenario seems kin

[jira] Resolved: (LUCENE-1842) Add reset(AttributeSource) method to AttributeSource

[ https://issues.apache.org/jira/browse/LUCENE-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Smith resolved LUCENE-1842. --- Resolution: Won't Fix I'm happy with just having the Tokenizer's provide the Attribu

[jira] Commented: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

[ https://issues.apache.org/jira/browse/LUCENE-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747943#action_12747943 ] Tim Smith commented on LUCENE-1859: --- it seems like the new TokenStream API

[jira] Created: (LUCENE-1859) TermAttributeImpl's buffer will never "shrink" if it grows too big

Issue Type: Bug Components: Analysis Affects Versions: 2.9 Reporter: Tim Smith This was also an issue with Token previously as well If a TermAttributeImpl is populated with a very long buffer, it will never be able to reclaim this memory Obviously, it can

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747645#action_12747645 ] Tim Smith commented on LUCENE-1849: --- bq. Out-of-order scoring is only used for

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747587#action_12747587 ] Tim Smith commented on LUCENE-1849: --- bq. I would prefer not to make a default here

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747441#action_12747441 ] Tim Smith commented on LUCENE-1849: --- bq. If we were to provide a default in Colle

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747075#action_12747075 ] Tim Smith commented on LUCENE-1849: --- bq. I think we should simply do nothing. Thi

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747059#action_12747059 ] Tim Smith commented on LUCENE-1849: --- I guess the question is: what variations d

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747051#action_12747051 ] Tim Smith commented on LUCENE-1849: --- i was just proposing AbstractCollecto

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747046#action_12747046 ] Tim Smith commented on LUCENE-1849: --- bq. we force them to think a little bit and

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747039#action_12747039 ] Tim Smith commented on LUCENE-1849: --- bq. I think this will get pretty messy

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747028#action_12747028 ] Tim Smith commented on LUCENE-1849: --- will do > Add OutOfOrderCollec

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747021#action_12747021 ] Tim Smith commented on LUCENE-1849: --- bq. Or just make it package private? This fla

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746928#action_12746928 ] Tim Smith commented on LUCENE-1849: --- I like the idea of this flag being private f

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746920#action_12746920 ] Tim Smith commented on LUCENE-1849: --- People tend to always reformat single

[jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746907#action_12746907 ] Tim Smith commented on LUCENE-1849: --- They would be convenience classes for pe

[jira] Created: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector

Type: Wish Components: Search Affects Versions: 2.9 Reporter: Tim Smith Priority: Minor Fix For: 2.9 I find myself always having to implement these methods, and i always return a constant (depending on if the collector can handle out of order hits

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746842#action_12746842 ] Tim Smith commented on LUCENE-1821: --- I allow caches to be loaded at commit time

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746839#action_12746839 ] Tim Smith commented on LUCENE-1821: --- bq. Have you done any benching here? I thin

Re: Finishing Lucene 2.9

Here's my vote on the topic of 2.9 vs 3.0 Next release should be 2.9 This release provides TONs of new APIs for things like Hit Collection, Scoring, Sorting, etc If all the deprecated stuff were removed for the "next" release, this would be impossible for any application developer to consume (unle

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746809#action_12746809 ] Tim Smith commented on LUCENE-1821: --- bq. Actually sorting (during collection) alr

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746662#action_12746662 ] Tim Smith commented on LUCENE-1821: --- can i at least argue for it being tagged for

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746643#action_12746643 ] Tim Smith commented on LUCENE-1821: --- Lot of new comments to respond to :) will tr

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746613#action_12746613 ] Tim Smith commented on LUCENE-1821: --- bq. thats a tough bunch of code to decid

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746600#action_12746600 ] Tim Smith commented on LUCENE-1821: --- well, you could go the route similar to the

[jira] Commented: (LUCENE-1842) Add reset(AttributeSource) method to AttributeSource

[ https://issues.apache.org/jira/browse/LUCENE-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746457#action_12746457 ] Tim Smith commented on LUCENE-1842: --- I would never use the Merging TokenStream

[jira] Commented: (LUCENE-1842) Add reset(AttributeSource) method to AttributeSource

[ https://issues.apache.org/jira/browse/LUCENE-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746455#action_12746455 ] Tim Smith commented on LUCENE-1842: --- The problem with the "MergeAnalyzer&qu

[jira] Commented: (LUCENE-1842) Add reset(AttributeSource) method to AttributeSource

[ https://issues.apache.org/jira/browse/LUCENE-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746452#action_12746452 ] Tim Smith commented on LUCENE-1842: --- Yes, i know that creating the Token

[jira] Commented: (LUCENE-1842) Add reset(AttributeSource) method to AttributeSource

[ https://issues.apache.org/jira/browse/LUCENE-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746450#action_12746450 ] Tim Smith commented on LUCENE-1842: --- Here's some pseudo code to hopefully f

[jira] Commented: (LUCENE-1842) Add reset(AttributeSource) method to AttributeSource

[ https://issues.apache.org/jira/browse/LUCENE-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746380#action_12746380 ] Tim Smith commented on LUCENE-1842: --- bq. still pay the price for filling the

[jira] Created: (LUCENE-1842) Add reset(AttributeSource) method to AttributeSource

: Analysis Reporter: Tim Smith Fix For: 2.9 Originally proposed in LUCENE-1826 Proposing the addition of the following method to AttributeSource {code} public void reset(AttributeSource input) { if (input == null) { throw new IllegalArgumentException("

[jira] Commented: (LUCENE-1826) All Tokenizer implementations should have constructors that take AttributeSource and AttributeFactory

[ https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746360#action_12746360 ] Tim Smith commented on LUCENE-1826: --- forked off the reset(AttributeSource

[jira] Commented: (LUCENE-1826) All Tokenizer implementations should have constructors that take AttributeSource and AttributeFactory

[ https://issues.apache.org/jira/browse/LUCENE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746356#action_12746356 ] Tim Smith commented on LUCENE-1826: --- i'll fork off another ticket for

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746263#action_12746263 ] Tim Smith commented on LUCENE-1821: --- I started integrating the per-segment searc

[jira] Created: (LUCENE-1839) Scorer.explain is deprecated but abstract, should have impl that throws UnsupportedOperationException

/browse/LUCENE-1839 Project: Lucene - Java Issue Type: Improvement Components: Search Reporter: Tim Smith Priority: Minor Fix For: 2.9 Suggest having Scorer implement explain to throw UnsupportedOperationException right now, i have

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746004#action_12746004 ] Tim Smith commented on LUCENE-1821: --- Looks like Filter should have another method a

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745991#action_12745991 ] Tim Smith commented on LUCENE-1821: --- what class is this getDocIdSet method on (lac

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745988#action_12745988 ] Tim Smith commented on LUCENE-1821: --- here's what you can do: {code} /** @d

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745977#action_12745977 ] Tim Smith commented on LUCENE-1821: --- {quote} It was an implementation detail. If

[jira] Commented: (LUCENE-1821) Weight.scorer() not passed doc offset for "sub reader"

[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745979#action_12745979 ] Tim Smith commented on LUCENE-1821: --- NOTE: if the leaf IndexSearcher were to be pa

  1   2   3   >