[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777419#action_12777419
]
Uwe Schindler commented on LUCENE-1257:
---
Robert: Is there anything else in contrib
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777449#action_12777449
]
Robert Muir commented on LUCENE-1257:
-
bq. If we find further Java5 conversions after
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777454#action_12777454
]
Simon Willnauer commented on LUCENE-1257:
-
We gonna reopen it in 3.0 anyway so
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1231#action_1231
]
Kay Kay commented on LUCENE-1257:
-
| Further updates of tests and internal APIs may
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776430#action_12776430
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
LUCENE-1257_heavy.patch
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775366#action_12775366
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776157#action_12776157
]
Uwe Schindler commented on LUCENE-1257:
---
I think for such complex thing, sometimes
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776161#action_12776161
]
Uwe Schindler commented on LUCENE-1257:
---
Oh god:
{code}
+
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776166#action_12776166
]
Robert Muir commented on LUCENE-1257:
-
bq. I think for such complex thing, sometimes
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776155#action_12776155
]
Robert Muir commented on LUCENE-1257:
-
simon, cool, I think it would be good if we
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776180#action_12776180
]
Kay Kay commented on LUCENE-1257:
-
I am not sure what the consensus w.r.t warnings are -
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776183#action_12776183
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
LUCENE-1257_lucil.patch
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776184#action_12776184
]
Uwe Schindler commented on LUCENE-1257:
---
Kay Kay: We only have SuppressWarnings at
About formatting. I know the how to contribute section of the Wiki warns
against gratuitous reformatting, but if *someone* with commit privileges
wanted to, they could format an entire tree in Eclipse from the context
menu of, say, the contrib directory. It'd have to be coordinated for a
moment
Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Erick Erickson [mailto:erickerick...@gmail.com]
Sent: Wednesday, November 11, 2009 1:27 AM
To: java-dev@lucene.apache.org
Subject: Re: [jira] Commented: (LUCENE-1257) Port to Java5
About formatting. I know the how
*Subject:* Re: [jira] Commented: (LUCENE-1257) Port to Java5
About formatting. I know the how to contribute section of the Wiki warns
against gratuitous reformatting, but if *someone* with commit privileges
wanted to, they could format an entire tree in Eclipse from the context
menu of, say
...@gmail.com]
*Sent:* Wednesday, November 11, 2009 1:27 AM
*To:* java-dev@lucene.apache.org
*Subject:* Re: [jira] Commented: (LUCENE-1257) Port to Java5
About formatting. I know the how to contribute section of the Wiki warns
against gratuitous reformatting, but if *someone* with commit
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12771643#action_12771643
]
Robert Muir commented on LUCENE-1257:
-
Uwe, thanks for taking a look. i think theres
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12771194#action_12771194
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12769778#action_12769778
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12769827#action_12769827
]
Kay Kay commented on LUCENE-1257:
-
{query}
I modified your benchmark changes to do this
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12769186#action_12769186
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12768136#action_12768136
]
Uwe Schindler commented on LUCENE-1257:
---
Created a new issue out of clone invariance
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12768234#action_12768234
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
-
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767852#action_12767852
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767953#action_12767953
]
Uwe Schindler commented on LUCENE-1257:
---
Thanks! Much cleaner code. -- Committed
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767977#action_12767977
]
Uwe Schindler commented on LUCENE-1257:
---
DM Smith: Can you open a new issue. This is
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767225#action_12767225
]
Uwe Schindler commented on LUCENE-1257:
---
bq. I did not touch StopFilter or
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767240#action_12767240
]
Uwe Schindler commented on LUCENE-1257:
---
I removed some unneeded patches.
Port to
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767241#action_12767241
]
Uwe Schindler commented on LUCENE-1257:
---
Comitted:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767242#action_12767242
]
Uwe Schindler commented on LUCENE-1257:
---
One note: I do not want to apply any
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767603#action_12767603
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
LUCENE-1257-MTQWF.patch
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767611#action_12767611
]
Kay Kay commented on LUCENE-1257:
-
| I updated the parser generator task to use Java 1.5.
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767617#action_12767617
]
Uwe Schindler commented on LUCENE-1257:
---
bq. What's the version of javacc being
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767033#action_12767033
]
Uwe Schindler commented on LUCENE-1257:
---
Committed
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767072#action_12767072
]
Uwe Schindler commented on LUCENE-1257:
---
bq. More set of patches in
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767087#action_12767087
]
Kay Kay commented on LUCENE-1257:
-
Uwe: Please feel free to go ahead and do it and commit
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767131#action_12767131
]
Uwe Schindler commented on LUCENE-1257:
---
Looks good!
Committed (with some
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767136#action_12767136
]
Uwe Schindler commented on LUCENE-1257:
---
I think test code rewrite is not so
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767138#action_12767138
]
Kay Kay commented on LUCENE-1257:
-
{quote} I think test code rewrite is not so important
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767140#action_12767140
]
Uwe Schindler commented on LUCENE-1257:
---
bq. IndexFileDeleter, IndexDeletePolicy
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767149#action_12767149
]
Uwe Schindler commented on LUCENE-1257:
---
bq. First cut version of the patch. If
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767152#action_12767152
]
Uwe Schindler commented on LUCENE-1257:
---
bq. LUCENE-1257_o.a.l.queryParser.patch
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767156#action_12767156
]
Robert Muir commented on LUCENE-1257:
-
{quote}
From your patch, it seems that you want
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767155#action_12767155
]
Uwe Schindler commented on LUCENE-1257:
---
{quote}
bq.
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767157#action_12767157
]
Uwe Schindler commented on LUCENE-1257:
---
Robert: Thanks!
But we should not generify
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767158#action_12767158
]
Robert Muir commented on LUCENE-1257:
-
Uwe, I agree. I think if we want to improve
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12767160#action_12767160
]
Uwe Schindler commented on LUCENE-1257:
---
So we just generify the ThreadLocal to
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766858#action_12766858
]
Uwe Schindler commented on LUCENE-1257:
---
I am working on it, I already fixed the
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766861#action_12766861
]
Uwe Schindler commented on LUCENE-1257:
---
again we have the date sorting bug in JIRA
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766869#action_12766869
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766931#action_12766931
]
Kay Kay commented on LUCENE-1257:
-
Thanks Uwe for helping with the patches.
Port to
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766949#action_12766949
]
Uwe Schindler commented on LUCENE-1257:
---
Kay Kay: You can also provide only one
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766948#action_12766948
]
Uwe Schindler commented on LUCENE-1257:
---
Committed:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766657#action_12766657
]
Uwe Schindler commented on LUCENE-1257:
---
Committed revision: 826035
Port to Java5
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12764315#action_12764315
]
Timo Nentwig commented on LUCENE-1257:
--
eclipse has a code cleanup tool that can
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12763083#action_12763083
]
Earwin Burrfoot commented on LUCENE-1257:
-
Not sure if that's the right issue, but
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12763087#action_12763087
]
Earwin Burrfoot commented on LUCENE-1257:
-
Also, we can remove tons of
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762131#action_12762131
]
Karl Wettin commented on LUCENE-1257:
-
bq. err... looks like perhaps its only hit once
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762012#action_12762012
]
Paul Elschot commented on LUCENE-1257:
--
Uwe, thanks for adding the changes.txt entry
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761836#action_12761836
]
Uwe Schindler commented on LUCENE-1257:
---
bq. Generification of Document. It makes
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761839#action_12761839
]
Timo Nentwig commented on LUCENE-1257:
--
Somewhat off-topic but in the course of
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761841#action_12761841
]
Uwe Schindler commented on LUCENE-1257:
---
Good idea!
Port to Java5
-
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761843#action_12761843
]
Paul Elschot commented on LUCENE-1257:
--
For the record, there is still some usage of
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761852#action_12761852
]
Uwe Schindler commented on LUCENE-1257:
---
I know, protected is also public from the
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761856#action_12761856
]
Paul Elschot commented on LUCENE-1257:
--
I would not expect that the protected methods
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761859#action_12761859
]
Uwe Schindler commented on LUCENE-1257:
---
Lets add a changes.txt entry in contrib
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761862#action_12761862
]
Karl Wettin commented on LUCENE-1257:
-
bq. Wait ... do you mean you got rid of some of
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761870#action_12761870
]
Karl Wettin commented on LUCENE-1257:
-
bq. Generification of Document. It makes now
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761872#action_12761872
]
Uwe Schindler commented on LUCENE-1257:
---
how that?
Port to Java5
-
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761874#action_12761874
]
Karl Wettin commented on LUCENE-1257:
-
bq. Generified ShingleMatrixFilter
Committed
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761875#action_12761875
]
Karl Wettin commented on LUCENE-1257:
-
bq. how that?
It asserted that a Document
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761877#action_12761877
]
Karl Wettin commented on LUCENE-1257:
-
bq. Fix for InstantiadexIndex compile error
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761878#action_12761878
]
Uwe Schindler commented on LUCENE-1257:
---
Ah ok, the list is Fieldable. That was
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761970#action_12761970
]
Uwe Schindler commented on LUCENE-1257:
---
Committed Revision: 821443 (Change some
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761975#action_12761975
]
Uwe Schindler commented on LUCENE-1257:
---
Committed revision: 821447 (o.a.l.messages
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761747#action_12761747
]
Uwe Schindler commented on LUCENE-1257:
---
StringBuffer changes committed revision:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761748#action_12761748
]
Mark Miller commented on LUCENE-1257:
-
bq. There are still some special cases in
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761755#action_12761755
]
Karl Wettin commented on LUCENE-1257:
-
bq. I vote to move to StringBuilder anyway if
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761754#action_12761754
]
Uwe Schindler commented on LUCENE-1257:
---
I already committed tha non-public-API
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761785#action_12761785
]
Mark Miller commented on LUCENE-1257:
-
{quote}Actually I patched the Snowball stemmer
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761212#action_12761212
]
Uwe Schindler commented on LUCENE-1257:
---
This patch is bit outdated.
I will try to
82 matches
Mail list logo