[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706373#action_12706373 ] Michael McCandless commented on LUCENE-1593: Patch looks good! I can confirm

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12706568#action_12706568 ] Shai Erera commented on LUCENE-1593: bq. MultiSearcher.search was creating too big an

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705947#action_12705947 ] Michael McCandless commented on LUCENE-1593: bq. I don't mind doing that. I

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-05 Thread Earwin Burrfoot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705977#action_12705977 ] Earwin Burrfoot commented on LUCENE-1593: - bq. So for this issue: create the

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705982#action_12705982 ] Michael McCandless commented on LUCENE-1593: bq. I assume the possibility to

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705552#action_12705552 ] Michael McCandless commented on LUCENE-1593: bq. Actually, if you request to

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705711#action_12705711 ] Shai Erera commented on LUCENE-1593: Ok will do that. I also would like to summarize

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-04 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705717#action_12705717 ] Yonik Seeley commented on LUCENE-1593: -- Whew - that's a lot of change just to

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705722#action_12705722 ] Shai Erera commented on LUCENE-1593: bq. Whew - that's a lot of change just to

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-04 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705732#action_12705732 ] Yonik Seeley commented on LUCENE-1593: -- bq. Or ... we can stop using BS at all and

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705776#action_12705776 ] Michael McCandless commented on LUCENE-1593: Shai your summary of what needs

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705874#action_12705874 ] Shai Erera commented on LUCENE-1593: bq. shouldn't we do the interface - abstract

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705441#action_12705441 ] Shai Erera commented on LUCENE-1593: Actually, if you request to sort-by-score and ask

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705251#action_12705251 ] Michael McCandless commented on LUCENE-1593: bq. But I think it's strange that

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705017#action_12705017 ] Michael McCandless commented on LUCENE-1593: bq. Unless we assume that

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705020#action_12705020 ] Michael McCandless commented on LUCENE-1593: {quote} Yonik does Solr have any

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705087#action_12705087 ] Shai Erera commented on LUCENE-1593: bq. And default Collector.acceptsDocsOutOfOrder

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705090#action_12705090 ] Michael McCandless commented on LUCENE-1593: bq. Do you propose it for

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705103#action_12705103 ] Michael McCandless commented on LUCENE-1593: bq. maybe we can change

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-05-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12705216#action_12705216 ] Shai Erera commented on LUCENE-1593: bq. I don't think we should add score back into

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704559#action_12704559 ] Michael McCandless commented on LUCENE-1593: Another things we should improve

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704594#action_12704594 ] Michael McCandless commented on LUCENE-1593: bq. Not in this issue though,

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704608#action_12704608 ] Shai Erera commented on LUCENE-1593: bq. BTW, I wonder if instead of

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704603#action_12704603 ] Michael McCandless commented on LUCENE-1593: BTW, I wonder if instead of

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704640#action_12704640 ] Yonik Seeley commented on LUCENE-1593: -- docsInOrder() would be an implementation

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704674#action_12704674 ] Yonik Seeley commented on LUCENE-1593: -- Query objects are relatively abstract.

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704692#action_12704692 ] Michael McCandless commented on LUCENE-1593: bq. What will TermQuery do? Oh:

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704693#action_12704693 ] Michael McCandless commented on LUCENE-1593: One further optimization can be

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704699#action_12704699 ] Michael McCandless commented on LUCENE-1593: bq. This is also not backward

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704703#action_12704703 ] Michael McCandless commented on LUCENE-1593: Yonik does Solr have any Scorers

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704702#action_12704702 ] Michael McCandless commented on LUCENE-1593: {quote} IndexSearcher creates the

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704705#action_12704705 ] Michael McCandless commented on LUCENE-1593: bq. BooleanScorer could be

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Marvin Humphrey (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704720#action_12704720 ] Marvin Humphrey commented on LUCENE-1593: - I made Weight a subclass of Query and

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704721#action_12704721 ] Yonik Seeley commented on LUCENE-1593: -- bq. Yonik does Solr have any Scorers that

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704785#action_12704785 ] Shai Erera commented on LUCENE-1593: bq. add an API to Collector for it to declare if

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704136#action_12704136 ] Shai Erera commented on LUCENE-1593: Hmmm .. I think DISI.start() breaks back-compat,

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704145#action_12704145 ] Shai Erera commented on LUCENE-1593: Ok - so after I posted the last comment I took my

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704198#action_12704198 ] Michael McCandless commented on LUCENE-1593: bq. So I'm now convinced this

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704232#action_12704232 ] Shai Erera commented on LUCENE-1593: bq, I'm not sure we can make such a change even

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12704323#action_12704323 ] Michael McCandless commented on LUCENE-1593: {quote} I think we should have an

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703540#action_12703540 ] Shai Erera commented on LUCENE-1593: bq. I think I'd lean towards the 12 impls now.

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-28 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703570#action_12703570 ] Michael McCandless commented on LUCENE-1593: bq. Ok sleeping did help.

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703588#action_12703588 ] Shai Erera commented on LUCENE-1593: bq. Good point - can you update HitQueue's

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703613#action_12703613 ] Shai Erera commented on LUCENE-1593: bq. But actually: the thing calling

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-28 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703600#action_12703600 ] Michael McCandless commented on LUCENE-1593: bq. I actually prefer to add a

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-28 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703667#action_12703667 ] Michael McCandless commented on LUCENE-1593: bq. The way I understand it

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703197#action_12703197 ] Michael McCandless commented on LUCENE-1593: The patch still has various logic

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703266#action_12703266 ] Shai Erera commented on LUCENE-1593: bq. he patch still has various logic to handle

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703329#action_12703329 ] Michael McCandless commented on LUCENE-1593: bq. I thought we agreed that

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703362#action_12703362 ] Shai Erera commented on LUCENE-1593: bq. I wonder if, instead, we could define an

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Earwin Burrfoot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703368#action_12703368 ] Earwin Burrfoot commented on LUCENE-1593: - Use FMPP? It is pretty nice and

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703373#action_12703373 ] Shai Erera commented on LUCENE-1593: Forgive my ignorance, but what is FMPP? And to

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Earwin Burrfoot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703382#action_12703382 ] Earwin Burrfoot commented on LUCENE-1593: - bq. Forgive my ignorance, but what is

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703396#action_12703396 ] Shai Erera commented on LUCENE-1593: bq.EG BooleanWeight.scorer(...) should call BS2's

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703404#action_12703404 ] Michael McCandless commented on LUCENE-1593: {quote} Some extensions of PQ may

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703410#action_12703410 ] Michael McCandless commented on LUCENE-1593: bq. Use FMPP? I think the first

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703412#action_12703412 ] Michael McCandless commented on LUCENE-1593: bq. the decision on which path

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702694#action_12702694 ] Michael McCandless commented on LUCENE-1593: BooleanScorer2 is package

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702695#action_12702695 ] Shai Erera commented on LUCENE-1593: I'm ready to attach the patch, still need to run

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702696#action_12702696 ] Shai Erera commented on LUCENE-1593: bq. as long as that doesn't then percolate up to

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702705#action_12702705 ] Michael McCandless commented on LUCENE-1593: bq. How should I do it? Just

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702717#action_12702717 ] Shai Erera commented on LUCENE-1593: Ok, I understand that now. So if you develop

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702724#action_12702724 ] Shai Erera commented on LUCENE-1593: Nothing wrong with that. Was just trying to think

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702343#action_12702343 ] Shai Erera commented on LUCENE-1593: Few updates (it's been long since I posted on

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-24 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702417#action_12702417 ] Michael McCandless commented on LUCENE-1593: bq. I tried to move to

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-24 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702418#action_12702418 ] Michael McCandless commented on LUCENE-1593: bq. Actually, I think

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702448#action_12702448 ] Shai Erera commented on LUCENE-1593: bq. I think it should work fine, for most types,

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-24 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702503#action_12702503 ] Michael McCandless commented on LUCENE-1593: bq. If it equals, it's also

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702651#action_12702651 ] Shai Erera commented on LUCENE-1593: bq. Same for BS2.score() and score(HC) -

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-16 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699656#action_12699656 ] Michael McCandless commented on LUCENE-1593: bq. if so, can we agree on the

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699237#action_12699237 ] Shai Erera commented on LUCENE-1593: Ok, so with the latest changes to LUCENE-1529, I

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-15 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699298#action_12699298 ] Mark Miller commented on LUCENE-1593: - In general, 3.0 gives us no extra in regards to

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699314#action_12699314 ] Shai Erera commented on LUCENE-1593: I thought that when we move to 3.0 we're not

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-15 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699321#action_12699321 ] Mark Miller commented on LUCENE-1593: - I believe if a user upgrades to release XX.9

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699344#action_12699344 ] Shai Erera commented on LUCENE-1593: bq. I believe if a user upgrades to release XX.9

Re: [jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-15 Thread Mark Miller
Shai Erera (JIRA) wrote: [ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699344#action_12699344 ] Shai Erera commented on LUCENE-1593: bq. I believe if a user

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-15 Thread Earwin Burrfoot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699524#action_12699524 ] Earwin Burrfoot commented on LUCENE-1593: - Lucene failed drop in replacement

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698674#action_12698674 ] Shai Erera commented on LUCENE-1593: I noticed that IndexSearcher has a ctor which

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698719#action_12698719 ] Michael McCandless commented on LUCENE-1593: bq. I thought these were

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698728#action_12698728 ] Shai Erera commented on LUCENE-1593: I would also like to change pq.adjustTop() and

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698731#action_12698731 ] Michael McCandless commented on LUCENE-1593: bq. I would also like to change

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698739#action_12698739 ] Shai Erera commented on LUCENE-1593: bq. what about JAR drop-in-ability? Darn it,

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698763#action_12698763 ] Shai Erera commented on LUCENE-1593: Wait, I think I was wrong before. I tried ant

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698798#action_12698798 ] Michael McCandless commented on LUCENE-1593: bq. So I ant clean and then ant

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698835#action_12698835 ] Shai Erera commented on LUCENE-1593: According to my understanding, test-tag runs the

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698838#action_12698838 ] Michael McCandless commented on LUCENE-1593: I thought what it was supposed to

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698367#action_12698367 ] Michael McCandless commented on LUCENE-1593: Those look like great

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698204#action_12698204 ] Michael McCandless commented on LUCENE-1593: bq. Change TSDC and TFC's code to

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698262#action_12698262 ] Michael McCandless commented on LUCENE-1593: Actually, I think BooleanScorer

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698273#action_12698273 ] Shai Erera commented on LUCENE-1593: This sounds like it should work, but since I'm

[jira] Commented: (LUCENE-1593) Optimizations to TopScoreDocCollector and TopFieldCollector

2009-04-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12697455#action_12697455 ] Michael McCandless commented on LUCENE-1593: See