[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720811#action_12720811
]
Uwe Schindler commented on LUCENE-1693:
---
Ah I understand the problem: As I told, if
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720820#action_12720820
]
Michael Busch commented on LUCENE-1693:
---
{quote}
Ah I understand the problem: As I
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720822#action_12720822
]
Uwe Schindler commented on LUCENE-1693:
---
I could change the calling chain:
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720846#action_12720846
]
Uwe Schindler commented on LUCENE-1693:
---
I have a solution to build in some
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720849#action_12720849
]
Mark Miller commented on LUCENE-1693:
-
Should I wait to put in the Highlighter update
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720854#action_12720854
]
Uwe Schindler commented on LUCENE-1693:
---
bq. Should I wait to put in the Highlighter
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720887#action_12720887
]
Michael Busch commented on LUCENE-1693:
---
I'm not convinced yet that we will be able
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720913#action_12720913
]
Michael Busch commented on LUCENE-1693:
---
You can probably fix CachingTokenFilter and
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720919#action_12720919
]
Michael Busch commented on LUCENE-1693:
---
Btw: SinkTokenizer in my patch has a small
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720926#action_12720926
]
Uwe Schindler commented on LUCENE-1693:
---
Exactly: The problem is in SinkTokenizer.
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720952#action_12720952
]
Uwe Schindler commented on LUCENE-1693:
---
The second test does not work, because it
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720984#action_12720984
]
Michael Busch commented on LUCENE-1693:
---
Go to bed, I'll review later... in meetings
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720031#action_12720031
]
Uwe Schindler commented on LUCENE-1693:
---
Why do you add a new class SmallToken? I
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720046#action_12720046
]
Michael Busch commented on LUCENE-1693:
---
{quote}
Why do you add a new class
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720052#action_12720052
]
Uwe Schindler commented on LUCENE-1693:
---
{quote}
bq. What was your concusion about
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720060#action_12720060
]
Michael Busch commented on LUCENE-1693:
---
{quote}
- If somebody implements the new
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720066#action_12720066
]
Uwe Schindler commented on LUCENE-1693:
---
{quote}
What if you currently have a filter
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720076#action_12720076
]
Shai Erera commented on LUCENE-1693:
I have a couple of TokenFilters that work that
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720081#action_12720081
]
Uwe Schindler commented on LUCENE-1693:
---
If you clone, you would not fall into the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720196#action_12720196
]
Michael Busch commented on LUCENE-1693:
---
But, the additional copying would affect
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720222#action_12720222
]
Michael McCandless commented on LUCENE-1693:
bq. What do you or others think
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720227#action_12720227
]
Grant Ingersoll commented on LUCENE-1693:
-
I think cloning is more prevalent than
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720230#action_12720230
]
Shai Erera commented on LUCENE-1693:
Perhaps I'm missing something, but I don't
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720236#action_12720236
]
Michael Busch commented on LUCENE-1693:
---
{quote}
Perhaps I'm missing something, but
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720237#action_12720237
]
Uwe Schindler commented on LUCENE-1693:
---
Grant: But with the new TokenStream API,
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720239#action_12720239
]
Uwe Schindler commented on LUCENE-1693:
---
bq. Currently e.g. SinkTokenizer always
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720240#action_12720240
]
Shai Erera commented on LUCENE-1693:
Thanks Michael. Given that, I don't think my
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720247#action_12720247
]
Uwe Schindler commented on LUCENE-1693:
---
I wanted to add one additional advantage of
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720244#action_12720244
]
Grant Ingersoll commented on LUCENE-1693:
-
Right, SinkTokenizer is only really
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720276#action_12720276
]
Michael Busch commented on LUCENE-1693:
---
The in 2.4 released CachingTokenFilter and
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720278#action_12720278
]
Uwe Schindler commented on LUCENE-1693:
---
The problem goes further:
If the users
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720279#action_12720279
]
Michael Busch commented on LUCENE-1693:
---
Also what happens if a user starts using
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720281#action_12720281
]
Michael Busch commented on LUCENE-1693:
---
{quote}
If the users move from the old
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720293#action_12720293
]
Michael Busch commented on LUCENE-1693:
---
{quote}
Also what happens if a user starts
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720440#action_12720440
]
Michael Busch commented on LUCENE-1693:
---
I haven't review the patch yet, but I have
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720508#action_12720508
]
Uwe Schindler commented on LUCENE-1693:
---
bq. is your patch backwards-compatible if a
101 - 136 of 136 matches
Mail list logo
