[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771473#action_12771473 ] Robert Muir commented on LUCENE-2014: - {quote} Does this make sense to insert a filter

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771367#action_12771367 ] Uwe Schindler commented on LUCENE-2014: --- Committed in 2.9, revision: 830876 I think

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771365#action_12771365 ] Robert Muir commented on LUCENE-2014: - bq. I also merged the BaseTokenStreamTestcase b

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771364#action_12771364 ] Uwe Schindler commented on LUCENE-2014: --- I also merged the BaseTokenStreamTestcase b

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771363#action_12771363 ] Robert Muir commented on LUCENE-2014: - Mike, its up to you. I was just analyzing some

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771362#action_12771362 ] Uwe Schindler commented on LUCENE-2014: --- I merged your changes into 2.9. I can commi

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771360#action_12771360 ] Michael McCandless commented on LUCENE-2014: Guys, how serious is this issue?

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771353#action_12771353 ] Robert Muir commented on LUCENE-2014: - Committed revision 830871 to trunk. I will tes

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771355#action_12771355 ] Uwe Schindler commented on LUCENE-2014: --- No prob. I also forgot about the bogus valu

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771351#action_12771351 ] Uwe Schindler commented on LUCENE-2014: --- ok. > position increment bug: smartcn > --

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771350#action_12771350 ] Robert Muir commented on LUCENE-2014: - bq. And how about 2.9.1? I will upload and tes

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771347#action_12771347 ] Uwe Schindler commented on LUCENE-2014: --- bq. I will commit soon. +1 And how about

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771345#action_12771345 ] Robert Muir commented on LUCENE-2014: - bq. I think the filter is fine how it is at the

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771344#action_12771344 ] Uwe Schindler commented on LUCENE-2014: --- bq. i worry about this clearAttributes solu

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771343#action_12771343 ] Robert Muir commented on LUCENE-2014: - Uwe exactly. so only remaining question is, do

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771342#action_12771342 ] Uwe Schindler commented on LUCENE-2014: --- Ah understand, because nobody resets the po

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771341#action_12771341 ] Robert Muir commented on LUCENE-2014: - bq. But the question is, why does IndexWriter f

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771338#action_12771338 ] Uwe Schindler commented on LUCENE-2014: --- Hihi, I know where the strange values come

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771339#action_12771339 ] Robert Muir commented on LUCENE-2014: - bq. Maybe we should use now BaseTokenStreamTest

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771336#action_12771336 ] Robert Muir commented on LUCENE-2014: - Uwe, yeah the only thing modifying it should be

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771335#action_12771335 ] Uwe Schindler commented on LUCENE-2014: --- This is the problem, you are right. I thoug

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771331#action_12771331 ] Uwe Schindler commented on LUCENE-2014: --- Hm hm But the StopFilter also adds the attr

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771332#action_12771332 ] Robert Muir commented on LUCENE-2014: - duh, this is the problem Uwe. WordTokenFilter

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771329#action_12771329 ] Robert Muir commented on LUCENE-2014: - Uwe, check this out. smartcn doesn't use Posit

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771327#action_12771327 ] Uwe Schindler commented on LUCENE-2014: --- I do not see the problem, from StopFilter:

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771323#action_12771323 ] Robert Muir commented on LUCENE-2014: - {quote} Is it a problem in StopWordFilter? {quo

[jira] Commented: (LUCENE-2014) position increment bug: smartcn

2009-10-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771322#action_12771322 ] Uwe Schindler commented on LUCENE-2014: --- Maybe we should use now BaseTokenStreamTest