[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789249#action_12789249
]
Michael McCandless commented on LUCENE-2133:
bq. I was just a little scared
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789377#action_12789377
]
Earwin Burrfoot commented on LUCENE-2133:
-
bq. I would like to hear the opionions
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789384#action_12789384
]
Mark Miller commented on LUCENE-2133:
-
bq. Something along these lines maybe?
And
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789398#action_12789398
]
Michael McCandless commented on LUCENE-2133:
bq. And we are back to 831
Yes
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788798#action_12788798
]
Michael McCandless commented on LUCENE-2133:
This patch is a good step forward
Mike:
Which of these do you think this patch *should* address before committing?
Just the last two?
As many as Christian has energy for G?
On Thu, Dec 10, 2009 at 12:24 PM, Michael McCandless (JIRA) j...@apache.org
wrote:
[
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788863#action_12788863
]
Christian Kohlschütter commented on LUCENE-2133:
bq. This patch is a good
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788874#action_12788874
]
Mark Miller commented on LUCENE-2133:
-
I don't know that back compat is really a
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788896#action_12788896
]
Christian Kohlschütter commented on LUCENE-2133:
bq. I don't know that
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788908#action_12788908
]
Mark Miller commented on LUCENE-2133:
-
bq. LUCENE-831 still requires a static
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788936#action_12788936
]
Christian Kohlschütter commented on LUCENE-2133:
bq. bq.LUCENE-831
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788951#action_12788951
]
Mark Miller commented on LUCENE-2133:
-
bq. That is, it adds a lot of duplicated code /
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788956#action_12788956
]
Christian Kohlschütter commented on LUCENE-2133:
Mark,
that's great to
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787387#action_12787387
]
Uwe Schindler commented on LUCENE-2133:
---
bq. The change of setNextReader() to use
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787502#action_12787502
]
Christian Kohlschütter commented on LUCENE-2133:
Hi Uwe,
your arguments
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787661#action_12787661
]
Michael McCandless commented on LUCENE-2133:
Christian, could you roll up all
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787667#action_12787667
]
Christian Kohlschütter commented on LUCENE-2133:
Michael,
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787699#action_12787699
]
Michael McCandless commented on LUCENE-2133:
bq. I have removed the test,
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787711#action_12787711
]
Mark Miller commented on LUCENE-2133:
-
There are a bunch or unrelated changes
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787715#action_12787715
]
Mark Miller commented on LUCENE-2133:
-
Hmm ... nevermind. The exception is related and
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787718#action_12787718
]
Christian Kohlschütter commented on LUCENE-2133:
Mark, could you please
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787720#action_12787720
]
Christian Kohlschütter commented on LUCENE-2133:
bq. Hmm ... nevermind.
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787729#action_12787729
]
Mark Miller commented on LUCENE-2133:
-
A couple more quick notes:
I know the
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787734#action_12787734
]
Mark Miller commented on LUCENE-2133:
-
It looks like FieldCacheTermsFilterDocIdSet is
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787743#action_12787743
]
Christian Kohlschütter commented on LUCENE-2133:
bq. I know the
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787748#action_12787748
]
Mark Miller commented on LUCENE-2133:
-
bq. I think it does not hurt either.
I didn't
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787750#action_12787750
]
Christian Kohlschütter commented on LUCENE-2133:
bq. It looks like
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787754#action_12787754
]
Christian Kohlschütter commented on LUCENE-2133:
bq. I didn't notice that
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787757#action_12787757
]
Uwe Schindler commented on LUCENE-2133:
---
After removing the very problematic change
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787759#action_12787759
]
Christian Kohlschütter commented on LUCENE-2133:
bq. And what about the
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787767#action_12787767
]
Mark Miller commented on LUCENE-2133:
-
bq. not bind the cache so hard to the
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787768#action_12787768
]
Christian Kohlschütter commented on LUCENE-2133:
Uwe, thanks a lot for
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787772#action_12787772
]
Uwe Schindler commented on LUCENE-2133:
---
bq. I still think it might be a little
[
https://issues.apache.org/jira/browse/LUCENE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787791#action_12787791
]
Christian Kohlschütter commented on LUCENE-2133:
bq. But we still want its
34 matches
Mail list logo
