[jira] Commented: (LUCENE-2195) Speedup CharArraySet if set is empty

2010-01-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801528#action_12801528 ] Robert Muir commented on LUCENE-2195: - bq. Thanks for updating it. I think this is goo

[jira] Commented: (LUCENE-2195) Speedup CharArraySet if set is empty

2010-01-16 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801252#action_12801252 ] Simon Willnauer commented on LUCENE-2195: - bq. I do not think unmodifiableset shou

[jira] Commented: (LUCENE-2195) Speedup CharArraySet if set is empty

2010-01-14 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800405#action_12800405 ] Simon Willnauer commented on LUCENE-2195: - any comments on the latest patch? > Sp

[jira] Commented: (LUCENE-2195) Speedup CharArraySet if set is empty

2010-01-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797710#action_12797710 ] Robert Muir commented on LUCENE-2195: - well then something must be decided: either we

[jira] Commented: (LUCENE-2195) Speedup CharArraySet if set is empty

2010-01-07 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797701#action_12797701 ] Yonik Seeley commented on LUCENE-2195: -- It's not quite the same - no method call for

[jira] Commented: (LUCENE-2195) Speedup CharArraySet if set is empty

2010-01-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797698#action_12797698 ] Robert Muir commented on LUCENE-2195: - Yonik, I disagree. I would rather see contains(

[jira] Commented: (LUCENE-2195) Speedup CharArraySet if set is empty

2010-01-07 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797692#action_12797692 ] Yonik Seeley commented on LUCENE-2195: -- Seems that this patch would just slow things

[jira] Commented: (LUCENE-2195) Speedup CharArraySet if set is empty

2010-01-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797686#action_12797686 ] Robert Muir commented on LUCENE-2195: - Simon I like it. this is useful for things like