[jira] Commented: (LUCENE-2200) Several final classes have non-overriding protected members

2010-01-09 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798370#action_12798370 ] Steven Rowe commented on LUCENE-2200: - All tests pass with the attached patch applied.

[jira] Commented: (LUCENE-2200) Several final classes have non-overriding protected members

2010-01-09 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798389#action_12798389 ] Simon Willnauer commented on LUCENE-2200: - Steve, I briefly looked at your patch.

[jira] Commented: (LUCENE-2200) Several final classes have non-overriding protected members

2010-01-09 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798396#action_12798396 ] Steven Rowe commented on LUCENE-2200: - FYI, all tests pass for me with the new version

[jira] Commented: (LUCENE-2200) Several final classes have non-overriding protected members

2010-01-10 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798495#action_12798495 ] Robert Muir commented on LUCENE-2200: - all tests pass and patch looks good to me. will

[jira] Commented: (LUCENE-2200) Several final classes have non-overriding protected members

2010-01-10 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798516#action_12798516 ] Simon Willnauer commented on LUCENE-2200: - Robert, when you commit this make sure