[jira] Commented: (LUCENE-2218) ShingleFilter improvements

2010-01-29 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12806402#action_12806402 ] Steven Rowe commented on LUCENE-2218: - Thanks, Robert. I plan on creating a Solr

[jira] Commented: (LUCENE-2218) ShingleFilter improvements

2010-01-29 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12806409#action_12806409 ] Steven Rowe commented on LUCENE-2218: - I see that SOLR-1674 introduced a new class

[jira] Commented: (LUCENE-2218) ShingleFilter improvements

2010-01-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12806495#action_12806495 ] Robert Muir commented on LUCENE-2218: - Steven, all the 3.0-analysis issues are listed

[jira] Commented: (LUCENE-2218) ShingleFilter improvements

2010-01-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12806228#action_12806228 ] Robert Muir commented on LUCENE-2218: - Steven: ok I reviewed this patch, I really like

[jira] Commented: (LUCENE-2218) ShingleFilter improvements

2010-01-17 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801502#action_12801502 ] Steven Rowe commented on LUCENE-2218: - New output from the fixed benchmark script - no

[jira] Commented: (LUCENE-2218) ShingleFilter improvements

2010-01-17 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801503#action_12801503 ] Steven Rowe commented on LUCENE-2218: - I think these patches are now ready to go.

[jira] Commented: (LUCENE-2218) ShingleFilter improvements

2010-01-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801630#action_12801630 ] Robert Muir commented on LUCENE-2218: - hey, want to break the benchmark out into a

[jira] Commented: (LUCENE-2218) ShingleFilter improvements

2010-01-17 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801649#action_12801649 ] Steven Rowe commented on LUCENE-2218: - bq. hey, want to break the benchmark out into a

[jira] Commented: (LUCENE-2218) ShingleFilter improvements

2010-01-17 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801651#action_12801651 ] Steven Rowe commented on LUCENE-2218: - bq. I made a trivial change:

[jira] Commented: (LUCENE-2218) ShingleFilter improvements

2010-01-16 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801341#action_12801341 ] Steven Rowe commented on LUCENE-2218: - The rewrite included some optimizations (e.g.,