[jira] Commented: (LUCENE-635) [PATCH] Decouple locking implementation from Directory implementation

[ http://issues.apache.org/jira/browse/LUCENE-635?page=comments#action_12431540 ] Michael McCandless commented on LUCENE-635: --- With this change, Directory on DB, Directory on RAM, etc., still work correctly. In fact you can completely

[jira] Commented: (LUCENE-635) [PATCH] Decouple locking implementation from Directory implementation

[ http://issues.apache.org/jira/browse/LUCENE-635?page=comments#action_12431666 ] Doron Cohen commented on LUCENE-635: We could (as you're suggesting) indeed extend FSDirectory so that it provided the low level methods required by a

[jira] Commented: (LUCENE-635) [PATCH] Decouple locking implementation from Directory implementation

[ http://issues.apache.org/jira/browse/LUCENE-635?page=comments#action_12431341 ] Doron Cohen commented on LUCENE-635: While updating my patch for 665 according the changes here, I noticed something - I may be wrong here - but it seems to

[jira] Commented: (LUCENE-635) [PATCH] Decouple locking implementation from Directory implementation

[ http://issues.apache.org/jira/browse/LUCENE-635?page=comments#action_12430748 ] Yonik Seeley commented on LUCENE-635: - I would lean towards keeping the small change to setDisabledLocks(). Meaning, it's only when you create a FSDirectory

[jira] Commented: (LUCENE-635) [PATCH] Decouple locking implementation from Directory implementation

[ http://issues.apache.org/jira/browse/LUCENE-635?page=comments#action_12429135 ] Michael McCandless commented on LUCENE-635: --- OK, does anyone have a strong opinion one way or another on these small changes? I would lean towards

[jira] Commented: (LUCENE-635) [PATCH] Decouple locking implementation from Directory implementation

[ http://issues.apache.org/jira/browse/LUCENE-635?page=comments#action_12428821 ] Michael McCandless commented on LUCENE-635: --- Thank you! I agree, locking is sneaky and requires very thorough review testing. Nice, I definitely like

[jira] Commented: (LUCENE-635) [PATCH] Decouple locking implementation from Directory implementation

[ http://issues.apache.org/jira/browse/LUCENE-635?page=comments#action_12428828 ] Yonik Seeley commented on LUCENE-635: - Yeah... those were the slight differences in external behavior I saw. That doesn't mean it's wrong, but it does mean we

[jira] Commented: (LUCENE-635) [PATCH] Decouple locking implementation from Directory implementation

[ http://issues.apache.org/jira/browse/LUCENE-635?page=comments#action_12427857 ] Michael McCandless commented on LUCENE-635: --- Has anyone had a chance to look at this patch? This should be fully backwards compatible: old APIs have

[jira] Commented: (LUCENE-635) [PATCH] Decouple locking implementation from Directory implementation

[ http://issues.apache.org/jira/browse/LUCENE-635?page=comments#action_12427906 ] Otis Gospodnetic commented on LUCENE-635: - I took a look at it a few weeks back. If nobody takes care of it, I'll look at it again and hopefully commit

[jira] Commented: (LUCENE-635) [PATCH] Decouple locking implementation from Directory implementation

[ http://issues.apache.org/jira/browse/LUCENE-635?page=comments#action_12427913 ] Michael McCandless commented on LUCENE-635: --- Awesome, thanks Otis! Have a great vacation! [PATCH] Decouple locking implementation from Directory