[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515797
]
Doug Cutting commented on LUCENE-781:
-
> I looked into the javadocs built with this patch and I can't see the nam
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515387
]
Yonik Seeley commented on LUCENE-781:
-
Returning false for isOptimized() seems fine.
> NPE in MultiReader.isCurr
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515384
]
Michael Busch commented on LUCENE-781:
--
If there are no objections against separating MultiReader into two class
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515057
]
Michael Busch commented on LUCENE-781:
--
> except that it makes the javadoc a bit odd, since the non-public class
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514961
]
Doug Cutting commented on LUCENE-781:
-
> MultiSegmentReader (package-protected) and MultiReader (public) that ext
: I think the cleanest solution here is it to separate MultiReader into two
: classes: MultiSegmentReader (package-protected) and MultiReader
: (public) that extends MultiSegmentReader.
i'm currently on vacation and don't have as much time to review patches as
i'd like (not because i'm on vacatio
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514823
]
Michael Busch commented on LUCENE-781:
--
I think the cleanest solution here is it to separate MultiReader into tw
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468436
]
Hoss Man commented on LUCENE-781:
-
comments based on cursory read of latest patch(es)...
1) I still think the IndexR
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468424
]
Daniel Naber commented on LUCENE-781:
-
I've attached an updated patch that now throws an exception for isCurrent(
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467957
]
Hoss Man commented on LUCENE-781:
-
Lemme put it this way: I'd rather write a new IndexReaderUtils class, with a
stat
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467953
]
Doron Cohen commented on LUCENE-781:
One could write an application that groups readers to multiReaders in more t
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467681
]
Hoss Man commented on LUCENE-781:
-
let's say we do implement isCurrent for a multi directory MultiReader as a loop
o
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467667
]
Doron Cohen commented on LUCENE-781:
I agree, except for isCurrent() - why not iterating the readers only for cas
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467655
]
Hoss Man commented on LUCENE-781:
-
so the fundamental issue is two radically different use cases of MultiReader --
a
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466930
]
Doron Cohen commented on LUCENE-781:
> ...either way, i'd still like clarification as to the orriginal point of t
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466927
]
Hoss Man commented on LUCENE-781:
-
i wasn't suggesting that the patch was flawed -- just trying to clarify what
circ
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466852
]
Doron Cohen commented on LUCENE-781:
I thought it would not break MultiReader, just do unnecessary work for that
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466849
]
Daniel Naber commented on LUCENE-781:
-
Hoss, you're right, this breaks MultiReader, I will revert the patch. Funn
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466843
]
Hoss Man commented on LUCENE-781:
-
i haven't looked atthe patch, but i'm a little confused by the issue summary
...
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466841
]
Daniel Naber commented on LUCENE-781:
-
Thanks for your feedback. I have committed my patch (but moved the testcas
[
https://issues.apache.org/jira/browse/LUCENE-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466636
]
Doron Cohen commented on LUCENE-781:
I checked - the fix is working and code seems right.
While we are looking a
21 matches
Mail list logo
