[ https://issues.apache.org/jira/browse/LUCENE-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644756#action_12644756 ]
[EMAIL PROTECTED] edited comment on LUCENE-1424 at 11/3/08 10:44 AM: --------------------------------------------------------------- Heres an early review patch. I switched range and prefix to use multiterm query, but its debatable if thats necessary. Prob a few clock cycles slower, and the benefits are slim beyond overall code design niceness (which counts a lot to me <g>). Just not sure every mutlitermquery would want to have to implement a constantscore version, and the amount of code reuse saved is low (it could do a bit more with something like getConstantScoreQuery, but thats not much either - I may put it in come to think of it). TODO: look over some comments maybe some tests for the constant score versions rangequery is not as expressive as constantscorequery, which can have separate inclusive/exclusive ends. When I was talking about deprecating constantscorequery being awkward, its wasnt really in the implementation sense (i think we can leave it as is), but more the deprecating one of the newest queries already :) Still don't consider that a huge deal though. was (Author: [EMAIL PROTECTED]): Heres an early review patch. I switched range and prefix to use multiterm query, but its debatable if thats necessary. Prob a few clock cycles slower, and the benefits are slim beyond overall code design niceness (which counts a lot to me <g>). Just not sure every mutlitermquery would want to have to implement a constantscore version, and the amount of code reuse saved is low (it could do a bit more with something like getFilteredEnum, but thats not much either). TODO: look over some comments maybe some tests for the constant score versions rangequery is not as expressive as constantscorequery, which can have separate inclusive/exclusive ends. When I was talking about deprecating constantscorequery being awkward, its wasnt really in the implementation sense (i think we can leave it as is), but more the deprecating one of the newest queries already :) Still don't consider that a huge deal though. > Add ConstantScorePrefixQuery and ConstantScoreWildcardQuery > ----------------------------------------------------------- > > Key: LUCENE-1424 > URL: https://issues.apache.org/jira/browse/LUCENE-1424 > Project: Lucene - Java > Issue Type: New Feature > Reporter: Mark Miller > Assignee: Michael McCandless > Priority: Minor > Attachments: LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch > > > If we want to be able to highlight these queries, they need to be added to > Lucene core or contrib (solr's WildCardFilter can be used to create the > ConstantScoreWildcardQuery). They are very useful anyway. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]