Re: Correct of Query.combine() bugs with new MultiSearcher

2005-04-27 Thread Wolf Siberski
Chuck Williams wrote: Thanks Erik. If you don't here more, I'm sure this fixes a whole class of problems and is better than the previous situation. I'm also confident that it will do the right thing for all the query types built into Lucene. To me Chucks patch also looks very good. In parall

Re: Correct of Query.combine() bugs with new MultiSearcher

2005-04-26 Thread Chuck Williams
Thanks Erik. If you don't here more, I'm sure this fixes a whole class of problems and is better than the previous situation. I'm also confident that it will do the right thing for all the query types built into Lucene. My remaining uncertainty concerns whether user query types might somehow

Re: Correct of Query.combine() bugs with new MultiSearcher

2005-04-26 Thread Erik Hatcher
I've confirmed Chuck's patch does fix the Highlighter test. I'm set to commit it once it gets the thumbs-up from Doug. Erik On Apr 26, 2005, at 4:58 PM, Chuck Williams wrote: As noted in the patch description I just submitted, it should be a complete, correct, robust (relative to possib

Correct of Query.combine() bugs with new MultiSearcher

2005-04-26 Thread Chuck Williams
As noted in the patch description I just submitted, it should be a complete, correct, robust (relative to possible user Query implementations) and reasonably optimal solution for Query.combine(). It also simplifies the previous methods, deleting all overrides of Query.combine() and Query.merge