[jira] Resolved: (LUCENE-1499) Minor refactoring to IndexFileNameFilter

2008-12-22 Thread Michael McCandless (JIRA)
, Patch Available] (was: [Patch Available, New]) Committed revision 728746. Thanks Shai! > Minor refactoring to IndexFileNameFilter > > > Key: LUCENE-1499 > URL: https://issues.apache.org/jira/bro

[jira] Assigned: (LUCENE-1499) Minor refactoring to IndexFileNameFilter

2008-12-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reassigned LUCENE-1499: -- Assignee: Michael McCandless > Minor refactoring to IndexFileNameFil

[jira] Updated: (LUCENE-1499) Minor refactoring to IndexFileNameFilter

2008-12-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-1499: --- Attachment: LUCENE-1499.patch > Minor refactoring to IndexFileNameFil

[jira] Created: (LUCENE-1499) Minor refactoring to IndexFileNameFilter

2008-12-22 Thread Shai Erera (JIRA)
Minor refactoring to IndexFileNameFilter Key: LUCENE-1499 URL: https://issues.apache.org/jira/browse/LUCENE-1499 Project: Lucene - Java Issue Type: Improvement Components: Index

Re: IndexFileNameFilter

2008-12-22 Thread Shai Erera
Sure On Mon, Dec 22, 2008 at 1:37 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > > I think this makes sense. Can you submit patch? Thanks Shai. > > Mike > > > Shai Erera wrote: > > Hi >> >> Is IndexFileNameFilter supposed to be a s

Re: IndexFileNameFilter

2008-12-22 Thread Michael McCandless
I think this makes sense. Can you submit patch? Thanks Shai. Mike Shai Erera wrote: Hi Is IndexFileNameFilter supposed to be a singleton (looks like it)? If so, shouldn't its constructor be private? Also, since it has a static getFilter() method, its singleton should also be priva

IndexFileNameFilter

2008-12-21 Thread Shai Erera
Hi Is IndexFileNameFilter supposed to be a singleton (looks like it)? If so, shouldn't its constructor be private? Also, since it has a static getFilter() method, its singleton should also be private. I checked and there are no references to either the singleton or the constructor outside