Re: Make TermScorer non final

2009-03-27 Thread Michael McCandless
On Wed, Mar 18, 2009 at 8:59 AM, Simon Willnauer wrote: > One thing I wanna mention aside: As long as TermScorer is final there > is no problem with the implementation beside some redundant code. The > TermScorer does not use the float score() method to calculate the > score in score(HitCollector

Re: Make TermScorer non final

2009-03-18 Thread Grant Ingersoll
On Mar 18, 2009, at 7:57 AM, Michael McCandless wrote: Coming from the discussions in LUCENE-1522 (improving highlighter), I think at some point we should merge Span*Query into their normal counterparts, if possible. Ie, there should be only one TermQuery that can do both what the current Ter

Re: Make TermScorer non final

2009-03-18 Thread Simon Willnauer
On Wed, Mar 18, 2009 at 1:32 PM, Mark Miller wrote: >>> In some usecases this could be important especially where the power of >>> a span query is not required. > > I think the power of a spanquery is required for payloads though - the term > query will not hit each position to do payload loading

Re: Make TermScorer non final

2009-03-18 Thread Mark Miller
In some usecases this could be important especially where the power of a span query is not required. I think the power of a spanquery is required for payloads though - the term query will not hit each position to do payload loading - there is no need for termquery to enumerate positions. Right

Re: Make TermScorer non final

2009-03-18 Thread Michael McCandless
Coming from the discussions in LUCENE-1522 (improving highlighter), I think at some point we should merge Span*Query into their normal counterparts, if possible. Ie, there should be only one TermQuery that can do both what the current TermQuery does, and also what SpanTermQuery does. It's able

Re: Make TermScorer non final

2009-03-18 Thread Grant Ingersoll
See https://issues.apache.org/jira/browse/LUCENE-1017 for some background. Have you measured BTQ versus the SpanTermQuery? Position based stuff is often slower. SpanQueries could use some performance assessments, that is for sure. Ideally, I think you should compare: TermQuery v. SpanTQ

Re: Make TermScorer non final

2009-03-18 Thread Simon Willnauer
Nothing different, I'm just concerned about the performance as the SpanQuerys take about twice as long as a term query. I run a little benchmark and found BoostingTermQuery being 1.5 times slower than TermQuery without any payloads in the index. In some usecases this could be important especially w

Re: Make TermScorer non final

2009-03-17 Thread Grant Ingersoll
What does PayloadTermQuery do that BoostingTermQuery doesn't do? -Grant On Mar 17, 2009, at 1:27 PM, Simon Willnauer wrote: Hi, I looked at TermScorer today in order implement a TermQuery to utilize Payloads from the index. I realized that this class is final in the current trunk. It's kind of

Make TermScorer non final

2009-03-17 Thread Simon Willnauer
Hi, I looked at TermScorer today in order implement a TermQuery to utilize Payloads from the index. I realized that this class is final in the current trunk. It's kind of obvious that is is declared final for optimization purposes. I wanna know if it is possible to make it non final in the next rel