I'll be attaching a new patch to JIRA-1844 after all the tests run, a bit
later this
evening. The two files I changed move/remove calls to
CheckUtils.check(query);
I arbitrarily limited the random query test in TestBooleanShouldMatch
to only checking the first 100, on the theory that we were at di
Erick Erickson wrote:
> I *finally* looked at the Jira and lo! you specifically identified the
> check method Someday I'll learn to look first, *then* explore.
> Siiigghhh.
No worries ;) So many half baked JIRA issues out there, it happens to
everyone - no way around it.
This way worked just a
I *finally* looked at the Jira and lo! you specifically identified the
check method Someday I'll learn to look first, *then* explore.
Siiigghhh.
Anyway, looking at things a bit more, I'm more confident that
TestCustomScoreQuery wouldn't lose anything by moving the
query check outside of the lo
Yep, I remember reading something about that, which is what
prodded me to take a look after I ran the tests and saw how
long they took
several more questions:
1> Why call QueryUtils.check in the first place? I admit when I
looked that method over, my eyes glazed. I try to take things
maybe we should link this issue to that as well:
https://issues.apache.org/jira/browse/LUCENE-1786
except that one is also a problem because it downloads zip files from the
internet, and if for some reason this fails, the test just passes...
one of these days maybe get off my duff and look at tha
+1 - I made a similar observation a while back and started an issue to
address Junit test speeds:
https://issues.apache.org/jira/browse/LUCENE-1844
Erick Erickson wrote:
> OK, I'm actually getting of my duff and trying to do something. And
> I'm off today feeling ill, so I have a bit of time. So
