Re: ScorerDocQueue.HeapedScorerDoc

2008-07-28 Thread eks dev
... to change semantics of these iterators not to return boolen but rather document Id with sentinel values. This would definitely reduce number of method invocations by factor 2 at least.--- {next() doc()} - next() It would be pretty easy to do that, just requires on one huge patch,

Re: ScorerDocQueue.HeapedScorerDoc

2008-07-27 Thread eks dev
people made this switch in last version as well. - Original Message From: Paul Elschot [EMAIL PROTECTED] To: java-dev@lucene.apache.org Sent: Sunday, 27 July, 2008 1:04:26 AM Subject: Re: ScorerDocQueue.HeapedScorerDoc Op Saturday 26 July 2008 23:09:06 schreef eks dev

Re: ScorerDocQueue.HeapedScorerDoc

2008-07-27 Thread Paul Elschot
: ScorerDocQueue.HeapedScorerDoc Op Saturday 26 July 2008 23:09:06 schreef eks dev: what is the reason to have HeapedScorerDoc class in ScorerDocQueue? Caching of the doc value? Yes. The underlying priority queue does log2(n) comparisons on them on some occasions. Does this bring

ScorerDocQueue.HeapedScorerDoc

2008-07-26 Thread eks dev
what is the reason to have HeapedScorerDoc class in ScorerDocQueue? Caching of the doc value? Does this bring anything compared to invoking doc() on Scorer, just curious, maybe I do not see something ovious... If doc is the reason, I would bet on doc()

Re: ScorerDocQueue.HeapedScorerDoc

2008-07-26 Thread Paul Elschot
Op Saturday 26 July 2008 23:09:06 schreef eks dev: what is the reason to have HeapedScorerDoc class in ScorerDocQueue? Caching of the doc value? Yes. The underlying priority queue does log2(n) comparisons on them on some occasions. Does this bring anything compared to invoking doc() on