Re: patch: adding IndexReader.isCurrent()

2005-06-06 Thread Radomir Mladenovic
Method isCurrrent() is a useful addition and I'm glad fix with timestamp use for initial version is finally commited. However, although version is not meaningful, I believe it should stay in API... The software I'm working on is using pair "version, document_id" as a fast reference to lucene docum

Re: patch: adding IndexReader.isCurrent()

2005-06-03 Thread Otis Gospodnetic
Well, Radomir, the person who asked about that method should be on java-dev@, so I'll assume he'll speak up if he needs that method. I think isCurrent() is good to go. Otis --- Daniel Naber <[EMAIL PROTECTED]> wrote: > On Friday 03 June 2005 23:51, Otis Gospodnetic wrote: > > > Isn't version

Re: patch: adding IndexReader.isCurrent()

2005-06-03 Thread Daniel Naber
On Friday 03 June 2005 23:51, Otis Gospodnetic wrote: > Isn't version a time stamp now? It starts as a time stamp, but then +1 is added for each change. So that number has no useful meaning I think. It's only useful for comparison. Or am I missing something? Regards Daniel -- http://www.dan

Re: patch: adding IndexReader.isCurrent()

2005-06-03 Thread Otis Gospodnetic
Isn't version a time stamp now? Somebody may still want to have that and keep track of that "long" outside Lucene. I think that's what that person wanted. Otis --- Daniel Naber <[EMAIL PROTECTED]> wrote: > On Friday 03 June 2005 23:18, Otis Gospodnetic wrote: > > > Looks good to me. You may

Re: patch: adding IndexReader.isCurrent()

2005-06-03 Thread Daniel Naber
On Friday 03 June 2005 23:18, Otis Gospodnetic wrote: > Looks good to me.  You may also want to add that instance method to > IndexReader that somebody asked for the other day... Well, the "version" isn't a version number anymore, at least not one that starts with 0 or 1. That's why those metho

Re: patch: adding IndexReader.isCurrent()

2005-06-03 Thread Otis Gospodnetic
Looks good to me. You may also want to add that instance method to IndexReader that somebody asked for the other day... Here: "Hello, Am I missing an obvious way to return version of already opened index? Static method IndexReader.getCurrentVersion() uses SegmentInfos to read version number fr

patch: adding IndexReader.isCurrent()

2005-06-03 Thread Daniel Naber
Hi, a patch similar to this was proposed a year ago but then got lost. I will apply it unless someone objects. It fixes the problem that you cannot safely use IndexReader.getCurrentVersion() to detect changes, as the version number is reset to 0 if the index is re-created. Also see http://www