Re: Possible bug in SpanNearQuery

2007-05-07 Thread Moti Nisenson
Sure thing. I actually haven't taken a sufficiently close look at NearSpansOrdered (I was concentrating more on NearSpansUnordered, which has got next to no documentation). - Moti On 5/7/07, Paul Elschot <[EMAIL PROTECTED]> wrote: Moti, I have not yet looked into all the details of your comme

Re: Possible bug in SpanNearQuery

2007-05-07 Thread Paul Elschot
Moti, I have not yet looked into all the details of your comments, but I remember I had some trouble in trying to define the precise semantics of NearSpansOrdered. I'll have another look at being more precise for the overlaps. NearSpansUnordered is a specialisation of the previous NearSpans for t

Re: Possible bug in SpanNearQuery

2007-05-07 Thread Moti Nisenson
Paul, The comment should be moved up into SpanNearQuery itself (as opposed to the comments in the package private implementation classes). Still though, that comment is inaccurate (regarding overlap - only "exact" overlap is handled). Here are some additional tests for SpanNearQuery. They all fai

Re: Possible bug in SpanNearQuery

2007-05-06 Thread Paul Elschot
Moti, I tried your test and it fails in the way you describe, however, I don't think the test shows a bug. Below is the javadoc comment for the package private class NearSpansOrdered. Would that be sufficient documentation for the ordered case? /** A Spans that is formed from the ordered subspa

Possible bug in SpanNearQuery

2007-05-06 Thread Moti Nisenson
Looking over the implementation of SpanNearQuery I came upon what looked like a bug. Below is a test which fails due to it. SpanNearQuery doesn't return all matching spans; once it's found a span it always increments the span of the clause appearing first in that span (ie. in the example below the