Re: File descriptor leak in ParallelReader.reopen()

2010-03-04 Thread Mark Miller
On 03/04/2010 06:52 PM, Justin wrote: Hi Mike and others, I have a test case for you (attached) that exhibits a file descriptor leak in ParallelReader.reopen(). I listed the OS, JDK, and snapshot of Lucene that I'm using in the source code. A loop adds just over 4000 documents to an index, r

Re: File descriptor leak in ParallelReader.reopen()

2010-03-04 Thread Justin
Has this changed since 2.4.1? Our application didn't explicitly close with 2.4.1 and that combination never had this problem. - Original Message From: Mark Miller To: java-user@lucene.apache.org Sent: Thu, March 4, 2010 6:00:02 PM Subject: Re: File descriptor le

RE: File descriptor leak in ParallelReader.reopen()

2010-03-04 Thread Uwe Schindler
() Uwe - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Justin [mailto:cry...@yahoo.com] > Sent: Friday, March 05, 2010 1:17 AM > To: java-user@lucene.apache.org > Subject: Re: File des

RE: File descriptor leak in ParallelReader.reopen()

2010-03-04 Thread Uwe Schindler
See my other mail for you file descriptor leak. A short note about your search code: You should not directly instantiate a TopScoreDocCollector but instead use the Searcher method that returns TopDocs. This has the benefit, that the searcher automatically chooses the right parameter for scoring

Re: File descriptor leak in ParallelReader.reopen()

2010-03-04 Thread Justin
We must have been getting lucky. Thanks Mark and Uwe! - Original Message From: Uwe Schindler To: java-user@lucene.apache.org Sent: Thu, March 4, 2010 6:20:56 PM Subject: RE: File descriptor leak in ParallelReader.reopen() That was always the same with reopen(). Its documented in

RE: File descriptor leak in ParallelReader.reopen()

2010-03-04 Thread Uwe Schindler
Sorry, small change: > You should not directly instantiate a TopScoreDocCollector but instead > use the Searcher method that returns TopDocs. This has the benefit, > that the searcher automatically chooses the right parameter for scoring > docs out/in order. In your example, search would be a litt

Re: File descriptor leak in ParallelReader.reopen()

2010-03-04 Thread Justin
Makes sense. Thanks for the tip! I haven't seen a response to my 2-pass scoring question, so maybe I've asked at least one difficult one. :-) - Original Message From: Uwe Schindler To: java-user@lucene.apache.org Sent: Thu, March 4, 2010 6:32:06 PM Subject: RE: File

Re: File descriptor leak in ParallelReader.reopen()

2010-03-05 Thread Justin
File descriptor leak in ParallelReader.reopen() We must have been getting lucky. Thanks Mark and Uwe! - Original Message From: Uwe Schindler To: java-user@lucene.apache.org Sent: Thu, March 4, 2010 6:20:56 PM Subject: RE: File descriptor leak in ParallelReader.reopen() That was always the

Re: File descriptor leak in ParallelReader.reopen()

2010-03-08 Thread Justin
ustin To: java-user@lucene.apache.org Sent: Fri, March 5, 2010 10:24:20 AM Subject: Re: File descriptor leak in ParallelReader.reopen() Out of curiosity, I downloaded 2.4.1 and made the necessary source code modifications (attached). There used to be some sort of file descriptor cleanup. Wit

Re: File descriptor leak in ParallelReader.reopen()

2010-03-08 Thread Michael McCandless
28%29 > > http://wiki.apache.org/lucene-java/NearRealtimeSearch > > > > > - Original Message > From: Justin > To: java-user@lucene.apache.org > Sent: Fri, March 5, 2010 10:24:20 AM > Subject: Re: File descriptor leak in ParallelReader.reopen() > > Out o

RE: File descriptor leak in ParallelReader.reopen()

2010-03-11 Thread Alexey Lef
ore/org/apache/lucene/index/IndexWriter.html#getReader%28%29 > > http://wiki.apache.org/lucene-java/NearRealtimeSearch > > > > > - Original Message > From: Justin > To: java-user@lucene.apache.org > Sent: Fri, March 5, 2010 10:24:20 AM > Subject: Re: File descriptor leak

Re: File descriptor leak in ParallelReader.reopen()

2010-03-12 Thread Michael McCandless
lowing >> references, although there is mention that reopen() will forward back to >> getReader(). >> >> http://lucene.apache.org/java/3_0_1/api/core/org/apache/lucene/index/IndexWriter.html#getReader%28%29 >> >> http://wiki.apache.org/lucene-java/NearRealtimeSea

RE: File descriptor leak in ParallelReader.reopen()

2010-03-12 Thread Alexey Lef
: Re: File descriptor leak in ParallelReader.reopen() Really, your app should not drop things on the floor and hope for the best you should explicitly close your IRs when you're done with them. I think the relevant change here was the removal of finalizers, under this issue: