Re: Feedback on the new doclet.

2016-02-17 Thread Kevin Rushforth
Hi Kumar, I am in the process of fixing up JavaFX to build with JDK 9 as a boot jdk, and I ran into an NPE in the doclet, that may be related to your change. I'll file a bug in JBS, but wanted to give you a heads-up. -- Kevin Kumar Srinivasan wrote: Hello everyone, The JEP 221 [1] was in

Re: Feedback on the new doclet.

2016-02-17 Thread Paul Benedict
Thank you Jon. One thing I recommend for improvement is removing the automatic highlighting of the first item in the search box results. First, the highlighting is gray so I first mistook it for a specialized header -- but it was really just the item selected. I think a yellowish color would be bet

Re: Feedback on the new doclet.

2016-02-17 Thread Jonathan Gibbons
Paul, Yes, we know about this one and it's on the list to be fixed. It's not specific to the new doclet; it happens in the ofl doclet as well, and is related to the transition to supporting HTML 5. That being said, with the recent arrival of the Search feature, the index frames on the left

Re: Feedback on the new doclet.

2016-02-17 Thread Paul Benedict
In the new doclet, I can no longer resize the "frames". I know they aren't HTML frames but the ability to resize them is important; the functionality should be restored via scripting. There are long package and class names in the wild. Cheers, Paul On Tue, Feb 16, 2016 at 3:41 PM, Kumar Srinivasa

Re: RFR(XS): 8150077: Due to a javac type inference issue, javadoc doesn't compile with a jdk prior to 8u40

2016-02-17 Thread Jonathan Gibbons
Looks OK to me. -- Jon On 02/17/2016 10:26 AM, Volker Simonis wrote: Hi, can I please have a review for the following small change which fixes two javac compilation errors during the build of javadoc if the boot jdk is older than 8u40: http://cr.openjdk.java.net/~simonis/webrevs/2016/8150077/

RE: Feedback on the new doclet.

2016-02-17 Thread Gunnar Morling
Hi, One thing I noticed is that links to specific types seem not to work as they used to do. E.g. this link to the Java 8 docs https://docs.oracle.com/javase/8/docs/api/index.html?javax/annotation/Generated.html gets me right to the docs of @Generated, whereas the new http://download.

RFR(XS): 8150077: Due to a javac type inference issue, javadoc doesn't compile with a jdk prior to 8u40

2016-02-17 Thread Volker Simonis
Hi, can I please have a review for the following small change which fixes two javac compilation errors during the build of javadoc if the boot jdk is older than 8u40: http://cr.openjdk.java.net/~simonis/webrevs/2016/8150077/ https://bugs.openjdk.java.net/browse/JDK-8150077 The first compilation