Re: RFR: 8154500 fix handling of jdk.launcher.patch.* in tests

2016-04-18 Thread Kumar Srinivasan
Looks fine to me. Kumar The conversion from using sun.boot.class.path to jdk.launcher.patch.* was imperfect, and becoming more so with the move towards using multiple -Xpatch options, in different system properties. A more complete/general solution would be shared infrastructure to fork to

RFR: 8154500 fix handling of jdk.launcher.patch.* in tests

2016-04-18 Thread Jonathan Gibbons
The conversion from using sun.boot.class.path to jdk.launcher.patch.* was imperfect, and becoming more so with the move towards using multiple -Xpatch options, in different system properties. A more complete/general solution would be shared infrastructure to fork tools and inherit selected jdk

Re: RFR: 8152818: Javadoc must support module options supported by javac.

2016-04-18 Thread Jonathan Gibbons
On 04/18/2016 11:33 AM, Martin Buchholz wrote: On Mon, Apr 18, 2016 at 11:11 AM, Jonathan Gibbons wrote: On 04/16/2016 03:45 PM, Martin Buchholz wrote: exec $JDK/bin/javadoc \ -d docs \ -Xdoclint:all \ -Xmodule:java.base \ -modulesourcepath "$JDKSRC/jdk/src/java.base/share/c

Re: Custom Taglets

2016-04-18 Thread Jonathan Gibbons
On 04/18/2016 09:52 AM, Robert Scholte wrote: Hi, in preparation of the DevoxxFr talk about Maven and Java9 by Hervé Boutemy and Arnaud Héritier I noticed some issues with custom taglets when generation Javadoc reports. For the developers of Maven plugins we have a set of Annotations or D

Re: RFR: 8152818: Javadoc must support module options supported by javac.

2016-04-18 Thread Martin Buchholz
On Mon, Apr 18, 2016 at 11:11 AM, Jonathan Gibbons wrote: > > > On 04/16/2016 03:45 PM, Martin Buchholz wrote: >> >> exec $JDK/bin/javadoc \ >>-d docs \ >>-Xdoclint:all \ >>-Xmodule:java.base \ >>-modulesourcepath "$JDKSRC/jdk/src/java.base/share/classes" \ > > > javadoc folk, > >

Re: RFR: 8152818: Javadoc must support module options supported by javac.

2016-04-18 Thread Jonathan Gibbons
On 04/16/2016 03:45 PM, Martin Buchholz wrote: exec $JDK/bin/javadoc \ -d docs \ -Xdoclint:all \ -Xmodule:java.base \ -modulesourcepath "$JDKSRC/jdk/src/java.base/share/classes" \ javadoc folk, This looks like a bug. Assuming Martin is using reasonably up to date JDK 9 code, yo

Custom Taglets

2016-04-18 Thread Robert Scholte
Hi, in preparation of the DevoxxFr talk about Maven and Java9 by Hervé Boutemy and Arnaud Héritier I noticed some issues with custom taglets when generation Javadoc reports. For the developers of Maven plugins we have a set of Annotations or DocletTags[1] to generate the plugin descriptor

Re: Javadoc custom Taglets

2016-04-18 Thread Jonathan Gibbons
FYI On 04/17/2016 04:03 AM, Robert Scholte wrote: Hi, in preparation of the DevoxxFr talk about Maven and Java9 by Hervé Boutemy and Arnaud Héritier I noticed some issues with custom taglets when generation Javadoc reports. For the developers of Maven plugins we have a set of Annotations or